resolve comments

Author: lanluo-nvidia

.github/workflows/build-test-linux-x86_64.yml

@@ -101,20 +101,32 @@ jobs:
         export CI_BUILD=1
         export LD_LIBRARY_PATH=/usr/lib64:$LD_LIBRARY_PATH
         pushd .
-        cd tests/py
-        python -m pip install -r requirements.txt
+        python -m pip install -r tests/py/requirements.txt
+        cov_param="--cov=torch_tensorrt --cov-report= --cov-config=pyproject.toml"
+
+        # test dynamo backend
+        python -m pytest -m critical ${cov_param} -n 4 tests/py/dynamo/backend/
+
+        # test dynamo models
+        python -m pytest -m critical ${cov_param} -ra --cov-append --ir dynamo tests/py/dynamo/models/
 
-        # test dynamo
-        python -m pytest -m critical --junitxml=${RUNNER_TEST_RESULTS_DIR}/dynamo_backend_test_results.xml -n 4 dynamo/backend/
-        python -m pytest -m critical -ra --junitxml=${RUNNER_TEST_RESULTS_DIR}/dynamo_models_result.xml --ir dynamo dynamo/models/
-        python -m pytest -m critical --junitxml=${RUNNER_TEST_RESULTS_DIR}/dynamo_automatic_plugin_results.xml dynamo/automatic_plugin/
-        python -m pytest -m critical --junitxml=${RUNNER_TEST_RESULTS_DIR}/dynamo_partitioning_results.xml dynamo/partitioning/
-        python -m pytest -m critical --junitxml=${RUNNER_TEST_RESULTS_DIR}/dynamo_lowering_results.xml dynamo/lowering/
-        python -m pytest -m critical --junitxml=${RUNNER_TEST_RESULTS_DIR}/dynamo_runtime_results.xml dynamo/runtime/
+        # test dynamo automatic plugin
+        python -m pytest -m critical ${cov_param} --cov-append tests/py/dynamo/automatic_plugin/
 
+        # test dynamo partitioning
+        python -m pytest -m critical ${cov_param} --cov-append tests/py/dynamo/partitioning/
+
+        # test dynamo lowering
+        python -m pytest -m critical ${cov_param} --cov-append tests/py/dynamo/lowering/
+
+        # test dynamo runtime
+        python -m pytest ${cov_param} --cov-append tests/py/dynamo/runtime/test_000_*
+        python -m pytest -m critical ${cov_param} --cov-append --ignore tests/py/dynamo/runtime/test_000_* tests/py/dynamo/runtime/ 
+        
         # test core
-        python -m pytest -m critical --junitxml=${RUNNER_TEST_RESULTS_DIR}/core_test_results.xml core/
-        popd
+        python -m pytest -m critical ${cov_param} --cov-append tests/py/core/
+        
+        coverage report --fail-under=20
 
   tests-py-torchscript-fe:
     name: Test torchscript frontend [Python]

pyproject.toml

@@ -77,6 +77,7 @@ dev = [
     "isort",
     "ruff",
     "pytest",
+    "pytest-cov",
     "pytest-xdist",
     "parameterized>=0.2.0",
     "expecttest==0.1.6",
@@ -102,25 +103,22 @@ Changelog = "https://github.com/pytorch/tensorrt/releases"
 package-dir = { "" = "py" }
 include-package-data = false
 
-[tool.pytest.ini_options]
-testpaths = ["tests/py"]
-addopts = "-ra --cov=py/torch_tensorrt --cov-report=html --cov-report=xml:coverage.xml --cov-config=pyproject.toml"
-
 [tool.coverage.paths]
 source = [
-    "py/torch_tensorrt/",
-    "*/site-packages/torch_tensorrt/"
+    "py/torch_tensorrt",
+    "*/site-packages/torch_tensorrt"
 ]
+
+[tool.coverage.run]
+source = ["torch_tensorrt"]
 omit = [
     "tests/*"
 ]
-
-[tool.coverage.run]
+data_file=".coverage"
 relative_files=true
 branch = true
 
 [tool.coverage.report]
-fail_under = 20
 skip_covered = true
 ignore_errors = true
 exclude_lines = [
@@ -143,9 +141,6 @@ exclude_lines = [
     "@(abc\\.)?abstractmethod",
 ]
 
-[tool.coverage.html]
-directory = "coverage_html"
-
 [tool.uv]
 package = true
 environments = ["sys_platform == 'linux'", "sys_platform == 'windows'"]

tests/py/dynamo/lowering/test_decompositions.py

@@ -9,7 +9,7 @@
 )
 from torch.testing._internal.common_utils import TestCase, run_tests
 from torch_tensorrt.dynamo.utils import ATOL, RTOL
-
+import pytest
 from ..testing_utilities import DECIMALS_OF_AGREEMENT, lower_graph_testing
 
 

tests/py/dynamo/models/test_reexport.py

@@ -71,6 +71,7 @@ def forward(self, x):
 
 
 @pytest.mark.unit
+@pytest.mark.critical
 def test_base_full_compile_multiple_outputs(ir):
     """
     This tests export serde functionality on a base model

tests/py/dynamo/partitioning/test_fast_partitioning.py

@@ -84,7 +84,7 @@ def forward(self, x, y):
             1,
             "All operators are supported, there should be one segment",
         )
-
+    @pytest.mark.critical
     def test_partition_partially_supported_multi_op(self):
         class PartiallySupportedMultiOp(torch.nn.Module):
             def __init__(self, *args, **kwargs) -> None:
@@ -114,6 +114,7 @@ def forward(self, x, y):
             "Unsupported operators interleave supported ones, expected 2 segments",
         )
 
+    @pytest.mark.critical
     def test_partition_partially_supported_with_torch_executed_ops(self):
         class PartiallySupportedMultiOp(torch.nn.Module):
             def __init__(self, *args, **kwargs) -> None:

tests/py/dynamo/runtime/test_000_convert_module_to_trt_engine.py

@@ -1,15 +1,14 @@
 import unittest
 
-import pytest
-import tensorrt as trt
 import torch
 import torch_tensorrt
 from torch_tensorrt.dynamo.runtime import PythonTorchTensorRTModule
 from torch_tensorrt.dynamo.utils import COSINE_THRESHOLD, cosine_similarity
 
+import tensorrt as trt
+
 
 class TestConvertModuleToTrtEngine(unittest.TestCase):
-    @pytest.mark.critical
     def test_convert_module(self):
         class Test(torch.nn.Module):
             def forward(self, a, b):

tests/py/requirements.txt

@@ -6,6 +6,7 @@ numpy
 parameterized>=0.2.0
 pytest>=8.2.1
 pytest-xdist>=3.6.1
+pytest-cov
 pyyaml
 timm>=1.0.3
 flashinfer-python;  python_version < "3.13"