Don't intercept TLS connections in tests.

This avoids mixing TLS termination by mitmproxy and by websockets.

Author: aaugustin

tests/proxy.py

@@ -1,5 +1,4 @@
 import asyncio
-import pathlib
 import threading
 import warnings
 
@@ -21,7 +20,7 @@ def __init__(self, on_running):
         self.running = on_running
         self.flows = []
 
-    def websocket_start(self, flow):
+    def tcp_start(self, flow):
         self.flows.append(flow)
 
     def get_flows(self):
@@ -48,7 +47,13 @@ async def run_proxy(cls):
         cls.proxy_loop = loop = asyncio.get_event_loop()
         cls.proxy_stop = stop = loop.create_future()
 
-        cls.proxy_options = options = Options(mode=[cls.proxy_mode])
+        cls.proxy_options = options = Options(
+            mode=[cls.proxy_mode],
+            # Don't intercept connections, but record them.
+            ignore_hosts=["^localhost:", "^127.0.0.1:", "^::1:"],
+            # This option requires mitmproxy 11.0.0, which requires Python 3.11.
+            show_ignored_hosts=True,
+        )
         cls.proxy_master = master = Master(options)
         master.addons.add(
             core.Core(),
@@ -58,12 +63,6 @@ async def run_proxy(cls):
             tlsconfig.TlsConfig(),
             RecordFlows(on_running=cls.proxy_ready.set),
         )
-        options.update(
-            # Use test certificate for TLS between client and proxy.
-            certs=[str(pathlib.Path(__file__).with_name("test_localhost.pem"))],
-            # Disable TLS verification between proxy and upstream.
-            ssl_insecure=True,
-        )
 
         task = loop.create_task(cls.proxy_master.run())
         await stop

tox.ini

@@ -15,8 +15,8 @@ commands =
 pass_env =
     WEBSOCKETS_*
 deps =
-    mitmproxy
-    python-socks[asyncio]
+    py311,py312,py313,coverage,maxi_cov: mitmproxy
+    py311,py312,py313,coverage,maxi_cov: python-socks[asyncio]
 
 [testenv:coverage]
 commands =