13403: Disable assertion rewriting for external modules - add tests

Author: Tusenka

changelog/13403.bugfix.rst

@@ -1 +1 @@
-Disable assertion rewriting of external modules
+Disable assertion for modules outside current working dir(cwd)

src/_pytest/assertion/__init__.py

@@ -110,7 +110,7 @@ def __init__(self, config: Config, mode) -> None:
         self.hook: rewrite.AssertionRewritingHook | None = None
 
     @property
-    def rootpath(self):
+    def invocation_path( self ):
         """Get current root path (current working dir)"""
         return str(self.config.invocation_params.dir)
 

src/_pytest/assertion/rewrite.py

@@ -239,7 +239,7 @@ def _should_rewrite(self, name: str, fn: str, state: AssertionState) -> bool:
         # rewritten if they match the naming convention for test files
         fn_path = PurePath(fn)
         for pat in self.fnpats:
-            if fnmatch_ex(pat, fn_path) and fn_path.is_relative_to(state.rootpath):
+            if fnmatch_ex(pat, fn_path) and fn_path.is_relative_to( state.invocation_path ):
                 state.trace(f"matched test file {fn!r}")
                 return True
 

src/_pytest/helpconfig.py

@@ -87,7 +87,7 @@ def pytest_addoption(parser: Parser) -> None:
         help="Trace considerations of conftest.py files",
     )
     group.addoption(
-        "--debug",
+            "--debug",
         action="store",
         nargs="?",
         const="pytestdebug.log",

testing/example_scripts/rewrite/pytest.ini

@@ -0,0 +1,2 @@
+[pytest]
+python_files = *.py

testing/example_scripts/rewrite/some_plugin/__init__.py

@@ -0,0 +1,7 @@
+import pytest
+
+@pytest.fixture
+def special_asserter():
+    def special_assert(x, y):
+        assert {'x': x} == {'x': y}
+    return special_assert

testing/example_scripts/rewrite/src/__init__.py

@@ -0,0 +1,4 @@
+def func(x: int, y: int):
+    assert x>0
+    assert y>0
+    return 0 if x == y else 1 if x>y else -1

testing/example_scripts/rewrite/src/main.py

@@ -0,0 +1,12 @@
+from _pytest.fixtures import fixture
+
+pytest_plugins = ["pytester", "some_plugin"]
+
+
+@fixture
+def b():
+    return 1
+
+@fixture
+def a():
+    return 2