13403: Disable assertion rewriting for external modules - add tests

Author: Tusenka

changelog/13403.bugfix.rst

@@ -1 +1 @@
-Disable assertion rewriting of external modules
+Disable assertion for modules outside current working dir(cwd)

src/_pytest/assertion/__init__.py

@@ -114,7 +114,7 @@ def __init__(self, config: Config, mode) -> None:
         self.hook: rewrite.AssertionRewritingHook | None = None
 
     @property
-    def rootpath(self):
+    def invocation_path( self ):
         """Get current root path (current working dir)"""
         return str(self.config.invocation_params.dir)
 

src/_pytest/assertion/rewrite.py

@@ -239,7 +239,7 @@ def _should_rewrite(self, name: str, fn: str, state: AssertionState) -> bool:
         # rewritten if they match the naming convention for test files
         fn_path = PurePath(fn)
         for pat in self.fnpats:
-            if fnmatch_ex(pat, fn_path) and fn_path.is_relative_to(state.rootpath):
+            if fnmatch_ex(pat, fn_path) and fn_path.is_relative_to( state.invocation_path ):
                 state.trace(f"matched test file {fn!r}")
                 return True
 

src/_pytest/helpconfig.py

@@ -87,7 +87,7 @@ def pytest_addoption(parser: Parser) -> None:
         help="Trace considerations of conftest.py files",
     )
     group.addoption(
-        "--debug",
+            "--debug",
         action="store",
         nargs="?",
         const="pytestdebug.log",

testing/example_scripts/rewrite/pytest.ini

@@ -0,0 +1,2 @@
+[pytest]
+python_files = *.py

testing/example_scripts/rewrite/some_plugin/__init__.py

@@ -0,0 +1,7 @@
+import pytest
+
+@pytest.fixture
+def special_asserter():
+    def special_assert(x, y):
+        assert {'x': x} == {'x': y}
+    return special_assert

testing/example_scripts/rewrite/src/__init__.py

@@ -0,0 +1,4 @@
+def func(x: int, y: int):
+    assert x>0
+    assert y>0
+    return 0 if x == y else 1 if x>y else -1

testing/example_scripts/rewrite/src/main.py

@@ -0,0 +1,12 @@
+from _pytest.fixtures import fixture
+
+pytest_plugins = ["pytester", "some_plugin"]
+
+
+@fixture
+def b():
+    return 1
+
+@fixture
+def a():
+    return 2

testing/example_scripts/rewrite/tests/__init__.py

@@ -0,0 +1,10 @@
+from typing import Callable
+
+from testing.example_scripts.rewrite.src.main import func
+
+
+def test_plugin(a: int, b: int, special_asserter: Callable[[int, int], bool]):
+    special_asserter(a, b)
+
+def test_func(a: int, b: int, special_asserter: Callable[[int, int], bool]):
+    assert {'res': func(a, b)} == {'res': 0}

testing/example_scripts/rewrite/tests/conftest.py

@@ -0,0 +1,3 @@
+def some_check(a: int):
+    assert abs(a)<2
+    return a in set(0, 1, -1)

testing/example_scripts/rewrite/tests/test_main.py

@@ -0,0 +1,5 @@
+home = /usr/bin
+include-system-site-packages = false
+version = 3.11.0
+executable = /usr/bin/python3.11
+command = /home/cas12/PycharmProjects/pytest-play/.venv/bin/python3 -m venv /home/cas12/PycharmProjects/pytest-play/testing/example_scripts/rewrite/venv

testing/example_scripts/rewrite/venv/lib64/python3.11/site-packages/external_lib/__init__.py

@@ -1297,13 +1297,13 @@ def test_meta_path():
         )
         assert pytester.runpytest().ret == 0
 
-    def test_rootpath_base(self, pytester: Pytester, monkeypatch: MonkeyPatch) -> None:
-        """Base cases for get rootpath from AssertionState"""
+    def test_invocation_dir(self, pytester: Pytester, monkeypatch: MonkeyPatch) -> None:
+        """Test get invocation param afrom AssertionState"""
         from _pytest.assertion import AssertionState
 
         config = pytester.parseconfig()
         state = AssertionState(config, "rewrite")
-        assert state.rootpath == str(config.invocation_params.dir)
+        assert state.invocation_path == str( config.invocation_params.dir )
         new_rootpath = str(pytester.path / "test")
         if not os.path.exists(new_rootpath):
             os.mkdir(new_rootpath)
@@ -1317,7 +1317,7 @@ def test_rootpath_base(self, pytester: Pytester, monkeypatch: MonkeyPatch) -> No
             ),
         )
         state = AssertionState(config, "rewrite")
-        assert state.rootpath == new_rootpath
+        assert state.invocation_path == new_rootpath
 
     @pytest.mark.skipif(
         sys.platform.startswith("win32"), reason="cannot remove cwd on Windows"
@@ -2062,9 +2062,7 @@ def fix(): return 1
     def test_assert_rewrite_correct_for_plugins(
         self, pytester: Pytester, hook: AssertionRewritingHook, monkeypatch
     ) -> None:
-        """
-        Plugins has always been rewritten regardless of the root dir
-        """
+        """Plugins has always been rewritten regardless of the root dir"""
         pkgdir = pytester.mkpydir("plugin")
         pkgdir.joinpath("__init__.py").write_text(
             "import pytest\n"