pylint.

Author: janiversen

examples/client_async.py

@@ -53,6 +53,7 @@ def setup_async_client(description=None, cmdline=None):
         server=False, description=description, cmdline=cmdline
     )
     _logger.info("### Create client object")
+    client = None
     if args.comm == "tcp":
         client = modbusClient.AsyncModbusTcpClient(
             args.host,

examples/client_sync.py

@@ -58,6 +58,7 @@ def setup_sync_client(description=None, cmdline=None):
         cmdline=cmdline,
     )
     _logger.info("### Create client object")
+    client = None
     if args.comm == "tcp":
         client = modbusClient.ModbusTcpClient(
             args.host,

examples/server_async.py

@@ -70,6 +70,7 @@ def setup_server(description=None, context=None, cmdline=None):
     args = helper.get_commandline(server=True, description=description, cmdline=cmdline)
     if context:
         args.context = context
+    datablock = None
     if not args.context:
         _logger.info("### Create datastore")
         # The datastores only respond to the addresses that are initialized
@@ -153,6 +154,7 @@ async def run_async_server(args):
     """Run server."""
     txt = f"### start ASYNC server, listening on {args.port} - {args.comm}"
     _logger.info(txt)
+    server = None
     if args.comm == "tcp":
         address = (args.host if args.host else "", args.port if args.port else None)
         server = await StartAsyncTcpServer(

examples/server_sync.py

@@ -66,6 +66,7 @@ def run_sync_server(args):
     """Run server."""
     txt = f"### start SYNC server, listening on {args.port} - {args.comm}"
     _logger.info(txt)
+    server = None
     if args.comm == "tcp":
         address = ("", args.port) if args.port else None
         server = StartTcpServer(

pymodbus/framer/socket_framer.py

@@ -60,7 +60,7 @@ def decode_data(self, data):
             }
         return {}
 
-    def frameProcessIncomingPacket(self, single, callback, slave, tid=None, **kwargs):  # noqa: C901
+    def frameProcessIncomingPacket(self, single, callback, slave, tid=None, **kwargs):
         """Process new packet pattern.
 
         This takes in a new request packet, adds it to the current

test/sub_client/test_client_sync.py

@@ -1,7 +1,6 @@
 """Test client sync."""
 import socket
 from itertools import count
-from test.conftest import mockSocket
 from unittest import mock
 
 import pytest
@@ -22,6 +21,7 @@
     ModbusSocketFramer,
     ModbusTlsFramer,
 )
+from test.conftest import mockSocket
 
 
 # ---------------------------------------------------------------------------#

test/sub_function_codes/test_bit_read_messages.py

@@ -7,7 +7,6 @@
 * Read Coils
 """
 import struct
-from test.conftest import MockContext
 
 from pymodbus.bit_read_message import (
     ReadBitsRequestBase,
@@ -16,6 +15,7 @@
     ReadDiscreteInputsRequest,
 )
 from pymodbus.pdu import ModbusExceptions
+from test.conftest import MockContext
 
 
 res = [True] * 21

test/sub_function_codes/test_bit_write_messages.py

@@ -6,15 +6,14 @@
 * Read/Write Discretes
 * Read Coils
 """
-from test.conftest import FakeList, MockContext
-
 from pymodbus.bit_write_message import (
     WriteMultipleCoilsRequest,
     WriteMultipleCoilsResponse,
     WriteSingleCoilRequest,
     WriteSingleCoilResponse,
 )
 from pymodbus.pdu import ModbusExceptions
+from test.conftest import FakeList, MockContext
 
 
 # ---------------------------------------------------------------------------#

test/sub_function_codes/test_register_read_messages.py

@@ -1,6 +1,4 @@
 """Test register read messages."""
-from test.conftest import FakeList, MockContext
-
 from pymodbus.pdu import ModbusExceptions
 from pymodbus.register_read_message import (
     ReadHoldingRegistersRequest,
@@ -12,6 +10,7 @@
     ReadWriteMultipleRegistersRequest,
     ReadWriteMultipleRegistersResponse,
 )
+from test.conftest import FakeList, MockContext
 
 
 TEST_MESSAGE = b"\x06\x00\x0a\x00\x0b\x00\x0c"

test/sub_function_codes/test_register_write_messages.py

@@ -1,6 +1,4 @@
 """Test register write messages."""
-from test.conftest import MockContext, MockLastValuesContext
-
 from pymodbus.payload import BinaryPayloadBuilder, Endian
 from pymodbus.pdu import ModbusExceptions
 from pymodbus.register_write_message import (
@@ -11,6 +9,7 @@
     WriteSingleRegisterRequest,
     WriteSingleRegisterResponse,
 )
+from test.conftest import MockContext, MockLastValuesContext
 
 
 # ---------------------------------------------------------------------------#

test/test_file_message.py

@@ -6,8 +6,6 @@
 * Read/Write Discretes
 * Read Coils
 """
-from test.conftest import MockContext
-
 from pymodbus.file_message import (
     FileRecord,
     ReadFifoQueueRequest,
@@ -18,6 +16,7 @@
     WriteFileRecordResponse,
 )
 from pymodbus.pdu import ModbusExceptions
+from test.conftest import MockContext  # pylint: disable=wrong-import-order
 
 
 TEST_MESSAGE = b"\x00\n\x00\x08\x00\x01\x00\x02\x00\x03\x00\x04"