Skip to content

Commit e72a1e3

Browse files
committed
Changing tests to work with different archs
Details: - test failed on x86_64 due to precision (used precise numbers) - migrated from deprecated failUnless* to assert* unittest methods
1 parent 958eecd commit e72a1e3

File tree

2 files changed

+29
-29
lines changed

2 files changed

+29
-29
lines changed

tests/test_yajl.py

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ def test_largestNumberAcceptableInIntegerCallback(self):
9797
self.assertSameTrace(
9898
"Called self.content_handler.yajl_integer(None, %s)\n" %sys.maxint
9999
)
100-
self.failUnlessRaises(yajl.YajlError, parser.parse, bad_json)
100+
self.assertRaises(yajl.YajlError, parser.parse, bad_json)
101101

102102
def test_ctxIsPassedToAllCallbacks(self):
103103
for func in [
@@ -124,7 +124,7 @@ def test_ctxIsPassedToAllCallbacks(self):
124124

125125
def test_bufSizeLessThanOneRaisesException(self):
126126
for buf_siz in range(-5, 1):
127-
self.failUnlessRaises(
127+
self.assertRaises(
128128
yajl.YajlConfigError,
129129
yajl.YajlParser, self.content_handler, buf_siz=buf_siz)
130130

@@ -135,7 +135,7 @@ def test_allowsNoCallbacks(self):
135135
def test_raisesExceptionOnInvalidJson(self):
136136
parser = yajl.YajlParser()
137137
invalid_json = StringIO('{ "a": }')
138-
self.failUnlessRaises(
138+
self.assertRaises(
139139
yajl.YajlError,
140140
parser.parse, invalid_json)
141141

@@ -161,55 +161,55 @@ def _yajl_gen_sample(self, g):
161161
g.yajl_gen_null()
162162
g.yajl_gen_bool(True)
163163
g.yajl_gen_integer(1)
164-
g.yajl_gen_double(2.2)
164+
g.yajl_gen_double(-6.5)
165165
g.yajl_gen_number(str(3))
166166
yield g.yajl_gen_get_buf()
167167
g.yajl_gen_string("b")
168168
g.yajl_gen_array_close()
169169
g.yajl_gen_map_close()
170170
yield g.yajl_gen_get_buf()
171171

172-
def test_YajlGen_streamedOUtput(self):
172+
def test_YajlGen_streamedOutput(self):
173173
g = yajl.YajlGen(beautify=False)
174174
results = list(self._yajl_gen_sample(g))
175-
self.failUnlessEqual(',"b"]}', results[1])
175+
self.assertEqual(',"b"]}', results[1])
176176

177-
def test_YajlGen_minimizeOUtput(self):
177+
def test_YajlGen_minimizeOutput(self):
178178
g = yajl.YajlGen(beautify=False)
179179
results = self._yajl_gen_sample(g)
180-
self.failUnlessEqual(
181-
'{"a":[null,true,1,2.2,3,"b"]}',
180+
self.assertEqual(
181+
'{"a":[null,true,1,-6.5,3,"b"]}',
182182
''.join(results))
183183

184-
def test_YajlGen_beautifyOUtput(self):
184+
def test_YajlGen_beautifyOutput(self):
185185
g = yajl.YajlGen(beautify=True)
186186
results = self._yajl_gen_sample(g)
187-
self.failUnlessEqual(
187+
self.assertEqual(
188188
'{\n'
189189
' "a": [\n'
190190
' null,\n'
191191
' true,\n'
192192
' 1,\n'
193-
' 2.2,\n'
193+
' -6.5,\n'
194194
' 3,\n'
195195
' "b"\n'
196196
' ]\n'
197197
'}\n',
198198
''.join(results))
199199

200-
def test_YajlGen_indentOUtput(self):
201-
g = yajl.YajlGen(beautify=True, indent="**")
200+
def test_YajlGen_indentOutput(self):
201+
g = yajl.YajlGen(beautify=True, indent="\t")
202202
results = self._yajl_gen_sample(g)
203-
self.failUnlessEqual(
203+
self.assertEqual(
204204
'{\n'
205-
'**"a": [\n'
206-
'****null,\n'
207-
'****true,\n'
208-
'****1,\n'
209-
'****2.2,\n'
210-
'****3,\n'
211-
'****"b"\n'
212-
'**]\n'
205+
'\t"a": [\n'
206+
'\t\tnull,\n'
207+
'\t\ttrue,\n'
208+
'\t\t1,\n'
209+
'\t\t-6.5,\n'
210+
'\t\t3,\n'
211+
'\t\t"b"\n'
212+
'\t]\n'
213213
'}\n',
214214
''.join(results))
215215

@@ -224,15 +224,15 @@ def test_load_yajl_raisesOSErrorIfYajlNotFound(self):
224224
yajl.load_yajl()
225225
except OSError, e:
226226
pass
227-
self.failUnless('Yajl shared object cannot be found.' in str(e))
227+
self.assertTrue('Yajl shared object cannot be found.' in str(e))
228228

229229
def test_get_yajl_version_correctlyParsesYajlVersion(self):
230230
for major in [0, 1, 3, 7]:
231231
for minor in [0, 1, 2, 5]:
232232
for micro in [0, 5, 10, 15, 20]:
233233
yajl_version = major * 10000 + minor * 100 + micro
234234
self.mock('yajl.yajl.yajl_version', returns=yajl_version)
235-
self.failUnlessEqual(
235+
self.assertEqual(
236236
'%s.%s.%s' %(major, minor, micro),
237237
yajl.get_yajl_version())
238238

@@ -241,10 +241,10 @@ def test_check_yajl_version_warnsOnlyWhenMismatchedVersions(self):
241241
self.mock('warnings.warn', [locals()])
242242
self.mock('yajl.__version__', mock_obj='1.1.1')
243243
self.mock('yajl.yajl_version', mock_obj='1.1.1')
244-
self.failUnless(yajl.check_yajl_version())
244+
self.assertTrue(yajl.check_yajl_version())
245245
self.assertSameTrace('')
246246
self.mock('yajl.yajl_version', mock_obj='1.1.0')
247-
self.failIf(yajl.check_yajl_version())
247+
self.assertFalse(yajl.check_yajl_version())
248248
self.assertSameTrace(
249249
"Called warnings.warn("
250250
"'Using Yajl-Py v1.1.1 with Yajl v1.1.0. "
@@ -253,4 +253,4 @@ def test_check_yajl_version_warnsOnlyWhenMismatchedVersions(self):
253253
)
254254

255255
def test_checkYajlPyAndYajlHaveSameVersion(self):
256-
self.failUnless(yajl.check_yajl_version())
256+
self.assertTrue(yajl.check_yajl_version())

tests/test_yajl_c.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ def assertSameAsGold(self, filename):
4545
expected = expected.replace('memory leaks:\t0\n', '')
4646
self.out.seek(0)
4747
got = self.out.read()
48-
self.failUnlessEqual(expected, got)
48+
self.assertEqual(expected, got)
4949

5050
def resetOutput(self):
5151
self.out.seek(0)

0 commit comments

Comments
 (0)