REQUEST. Include Insurance in price

[xtalia]

Including Insurance price (from bronze to platinum) gives to modulate price for pvp situation. In settings may to operate type of Insurance.
Example: Total Price 234M ISK (With Insurance 123M).

[blitzmann]

Hi there!

Good news, this is a planned feature! I expect it would be a setting the user can switch on/off somehow, but it's definitely something I want to do.

Bad news: might be a few months. I have a few other things flying under the radar right now that are precursors to getting this feature done. But once those are implemented, it should be a piece of cake :)

[feyyd]

I started work on this today, already retrieving data but would love some input where and how to display the data. for debugging purposes I've just hooked right into the Character Editor -> get skills to confirm the data is being sent.

I'm thinking we could put the currently selected ships insurance price/payouts in the Price readout tab on the far right. Perhaps in its own tab so the user can toggle it on/off. I think this data is refreshed daily so might want to implement some sort of caching scheme which I saw notes in the comments for.

For now I'll prototype it to display in the Price section. I'm also going to retrieve the insurance data on every startup for this prototype but assuming a caching scheme can be worked out in the future.

[blitzmann]

@feyyd if you right click the price pane, there's a "include in total" thing thatt the user can use to select what they want to include in the total. I think this would be a good place for it for now, make a new option for "insurance". If it's selected, could also add it to the ship total that is displayed, and have a tooltip break it down if the user wishes to see the individual components.

Additionally, while the default shown could be Plat (or whatever the user selects in preferences), we could also show the list of all insurance prices in the ships Info window.

As for gathering the data, yeah, it will need to be cached somehow. Unsure just yet of how we should do this. Are you saving this info to the database?

[feyyd]

currently not using any database, just doing an ESI call in its own thread every time Pyfa loads and saving it in memory (Insurance class). I was thinking of just adding a separate pane for Insurance similar to the Price pane.

[feyyd]

Did a little more work on this, added an option to the Stats panels so we can enable/disable. Just doing a little cleanup work/testing. I'll prob need your advice on where/when to load or cache. Right now I'm just launching a new thread in pyfa.py which can't be the right spot.

This is the code in pyfa.py that runs right before pyfa.MainLoop gets called. It had to be called after wx.Init() because of a wx callback and I wasn't sure where to put it

from service.insurance import Insurance
sInsurance = Insurance.getInstance()
sInsurance.apiFetch(lambda response: pyfalog.debug(str(response)))

I pushed changes to https://github.com/feyyd/Pyfa/tree/feature/1463-insurance if you want to check out changes but going to hold back on pull request until I get your feedback on a few of these things.

[feyyd]

Asked for feedback on tweetfleet and consensus seems to be they want column labels. Also added a difference field as well.

[feyyd]

I added a context menu for column display, but it seems like there isn't a good way to repopulate the stats panels. for now i just put text in the context menu "(Restart Required)"

put this pull request up on #1699