Skip to content

Commit 530d59a

Browse files
committed
chore: respond to comments
1 parent 6f7d540 commit 530d59a

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

tests/feature_resolution_editions.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -237,8 +237,7 @@ tape.test("feature resolution inheritance oneofs", function(test) {
237237
var rootEditionsOverriden = protobuf.parse(`
238238
edition = "2023";
239239
option features.(abc).d_e = deeply_nested_false;
240-
message Message {
241-
240+
message Message {∂
242241
oneof SomeOneOf {
243242
option features.json_format = LEGACY_BEST_EFFORT;
244243
int32 a = 13;
@@ -267,14 +266,14 @@ tape.test("feature resolution inheritance oneofs to field", function(test) {
267266
oneof SomeOneOf {
268267
option features.json_format = LEGACY_BEST_EFFORT;
269268
int32 a = 13;
270-
string b = 14;
269+
string b = 14 [features.json_format = ALLOW];
271270
}
272271
}`).root.resolveAll();
273272

274273
test.same(rootEditionsOverriden.lookup("SomeOneOf").fieldsArray.find(x => x.name === 'b')._features, {
275274
enum_type: 'OPEN',
276275
field_presence: 'EXPLICIT',
277-
json_format: 'LEGACY_BEST_EFFORT',
276+
json_format: 'ALLOW',
278277
message_encoding: 'LENGTH_PREFIXED',
279278
repeated_field_encoding: 'PACKED',
280279
utf8_validation: 'VERIFY',
@@ -294,7 +293,9 @@ tape.test("feature resolution inheritance file to extensions", function(test) {
294293
extend Message {
295294
int32 bar = 10 [features.utf8_validation = NONE];
296295
}
297-
message Message {}`).root.resolveAll();
296+
message Message {
297+
option features.field_presence = IMPLICIT;
298+
}`).root.resolveAll();
298299

299300
test.same(rootEditionsOverriden.lookup(".bar")._features, {
300301
enum_type: 'OPEN',

0 commit comments

Comments
 (0)