Skip to content

Commit 23c8ab9

Browse files
committed
respond to comments
1 parent 530d59a commit 23c8ab9

File tree

1 file changed

+2
-17
lines changed

1 file changed

+2
-17
lines changed

tests/feature_resolution_editions.js

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -237,11 +237,11 @@ tape.test("feature resolution inheritance oneofs", function(test) {
237237
var rootEditionsOverriden = protobuf.parse(`
238238
edition = "2023";
239239
option features.(abc).d_e = deeply_nested_false;
240-
message Message {
240+
message Message {
241241
oneof SomeOneOf {
242242
option features.json_format = LEGACY_BEST_EFFORT;
243243
int32 a = 13;
244-
string b = 14;
244+
string b = 14 [features.json_format = ALLOW];
245245
}
246246
}`).root.resolveAll();
247247

@@ -255,21 +255,6 @@ tape.test("feature resolution inheritance oneofs", function(test) {
255255
'(abc)': { d_e: 'deeply_nested_false' }
256256
})
257257

258-
test.end();
259-
});
260-
261-
tape.test("feature resolution inheritance oneofs to field", function(test) {
262-
var rootEditionsOverriden = protobuf.parse(`
263-
edition = "2023";
264-
option features.(abc).d_e = deeply_nested_false;
265-
message Message {
266-
oneof SomeOneOf {
267-
option features.json_format = LEGACY_BEST_EFFORT;
268-
int32 a = 13;
269-
string b = 14 [features.json_format = ALLOW];
270-
}
271-
}`).root.resolveAll();
272-
273258
test.same(rootEditionsOverriden.lookup("SomeOneOf").fieldsArray.find(x => x.name === 'b')._features, {
274259
enum_type: 'OPEN',
275260
field_presence: 'EXPLICIT',

0 commit comments

Comments
 (0)