Skip to content

Commit 53c5bb1

Browse files
committed
Call Long.fromNumber in assertions instead of casting, fixes #22
1 parent 74f9fb0 commit 53c5bb1

File tree

6 files changed

+91
-90
lines changed

6 files changed

+91
-90
lines changed

dist/ByteBufferAB.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -700,9 +700,9 @@
700700
var relative = typeof offset === 'undefined';
701701
if (relative) offset = this.offset;
702702
if (!this.noAssert) {
703-
if (typeof value === 'number' && value % 1 === 0)
704-
value |= 0;
705-
else if (!(value && value instanceof Long))
703+
if (typeof value === 'number')
704+
value = Long.fromNumber(value);
705+
if (typeof value !== 'number' && !(value && value instanceof Long))
706706
throw(new TypeError("Illegal value: "+value+" (not an integer or Long)"));
707707
if (typeof offset !== 'number' || offset % 1 !== 0)
708708
throw(new TypeError("Illegal offset: "+offset+" (not an integer)"));
@@ -779,9 +779,9 @@
779779
var relative = typeof offset === 'undefined';
780780
if (relative) offset = this.offset;
781781
if (!this.noAssert) {
782-
if (typeof value === 'number' && value % 1 === 0)
783-
value |= 0;
784-
else if (!(value && value instanceof Long))
782+
if (typeof value === 'number')
783+
value = Long.fromNumber(value);
784+
if (typeof value !== 'number' && !(value && value instanceof Long))
785785
throw(new TypeError("Illegal value: "+value+" (not an integer or Long)"));
786786
if (typeof offset !== 'number' || offset % 1 !== 0)
787787
throw(new TypeError("Illegal offset: "+offset+" (not an integer)"));
@@ -1239,9 +1239,9 @@
12391239
var relative = typeof offset === 'undefined';
12401240
if (relative) offset = this.offset;
12411241
if (!this.noAssert) {
1242-
if (typeof value === 'number' && value % 1 === 0)
1243-
value |= 0;
1244-
else if (!(value && value instanceof Long))
1242+
if (typeof value === 'number')
1243+
value = Long.fromNumber(value);
1244+
if (typeof value !== 'number' && !(value && value instanceof Long))
12451245
throw(new TypeError("Illegal value: "+value+" (not an integer or Long)"));
12461246
if (typeof offset !== 'number' || offset % 1 !== 0)
12471247
throw(new TypeError("Illegal offset: "+offset+" (not an integer)"));

0 commit comments

Comments
 (0)