Events: add support for catalog-level events

Author: adutra

catalog/format/iceberg/src/main/java/org/projectnessie/catalog/formats/iceberg/rest/IcebergCatalogOperation.java

@@ -26,28 +26,51 @@
 import org.immutables.value.Value;
 import org.projectnessie.catalog.formats.iceberg.rest.IcebergUpdateRequirement.AssertCreate;
 import org.projectnessie.catalog.model.ops.CatalogOperation;
+import org.projectnessie.catalog.model.ops.CatalogOperationType;
 import org.projectnessie.model.Content;
+import org.projectnessie.model.Content.Type;
 import org.projectnessie.model.ContentKey;
 import org.projectnessie.nessie.immutables.NessieImmutable;
 
 /** Server-side representation of Iceberg metadata updates. */
 @NessieImmutable
 @JsonSerialize(as = ImmutableIcebergCatalogOperation.class)
 @JsonDeserialize(as = ImmutableIcebergCatalogOperation.class)
-public abstract class IcebergCatalogOperation implements CatalogOperation {
+public abstract class IcebergCatalogOperation implements CatalogOperation<IcebergMetadataUpdate> {
+
+  @Value.Default
   @Override
-  public abstract ContentKey getKey();
+  public CatalogOperationType getOperationType() {
+    // note: the default impl cannot detect DROP operations
+    boolean hasAssertCreate = hasRequirement(AssertCreate.class);
+    if (getContentType().equals(Type.ICEBERG_TABLE)) {
+      return hasAssertCreate ? CatalogOperationType.CREATE_TABLE : CatalogOperationType.ALTER_TABLE;
+    } else if (getContentType().equals(Type.ICEBERG_VIEW)) {
+      return hasAssertCreate ? CatalogOperationType.CREATE_VIEW : CatalogOperationType.ALTER_VIEW;
+    } else {
+      throw new IllegalArgumentException("Unsupported content type: " + getContentType());
+    }
+  }
 
   @Override
-  public abstract Content.Type getType();
+  public abstract ContentKey getContentKey();
 
   @Override
+  public abstract Content.Type getContentType();
+
+  /**
+   * The logical warehouse name where this operation will occur. Must correspond to a warehouse
+   * configured under {@code nessie.catalog.warehouses.<name>}.
+   *
+   * <p>If not set, the default warehouse will be used.
+   */
   @Nullable
   public abstract String warehouse();
 
-  public abstract List<IcebergMetadataUpdate> updates();
+  @Override
+  public abstract List<IcebergMetadataUpdate> getUpdates();
 
-  public abstract List<IcebergUpdateRequirement> requirements();
+  public abstract List<IcebergUpdateRequirement> getRequirements();
 
   public static Builder builder() {
     return ImmutableIcebergCatalogOperation.builder();
@@ -56,13 +79,13 @@ public static Builder builder() {
   @JsonIgnore
   @Value.Derived
   public boolean hasRequirement(Class<? extends IcebergUpdateRequirement> requirement) {
-    return requirements().stream().anyMatch(requirement::isInstance);
+    return getRequirements().stream().anyMatch(requirement::isInstance);
   }
 
   @JsonIgnore
   @Value.Derived
   public boolean hasUpdate(Class<? extends IcebergMetadataUpdate> update) {
-    return updates().stream().anyMatch(update::isInstance);
+    return getUpdates().stream().anyMatch(update::isInstance);
   }
 
   /**
@@ -73,7 +96,7 @@ public boolean hasUpdate(Class<? extends IcebergMetadataUpdate> update) {
   @Value.Derived
   public <T, U extends IcebergMetadataUpdate> T getSingleUpdateValue(
       Class<U> update, Function<U, T> mapper) {
-    return updates().stream()
+    return getUpdates().stream()
         .filter(update::isInstance)
         .map(update::cast)
         .map(mapper)
@@ -91,10 +114,10 @@ public <T, U extends IcebergMetadataUpdate> T getSingleUpdateValue(
   @Value.Check
   protected void check() {
     if (hasRequirement(AssertCreate.class)) {
-      if (requirements().size() > 1) {
+      if (getRequirements().size() > 1) {
         throw new IllegalArgumentException(
             "Invalid create requirements: "
-                + requirements().stream()
+                + getRequirements().stream()
                     .filter(r -> !(r instanceof AssertCreate))
                     .map(Object::getClass)
                     .map(Class::getSimpleName)
@@ -105,17 +128,18 @@ protected void check() {
 
   @SuppressWarnings("unused")
   public interface Builder {
-    @CanIgnoreReturnValue
-    Builder from(CatalogOperation instance);
 
     @CanIgnoreReturnValue
     Builder from(IcebergCatalogOperation instance);
 
     @CanIgnoreReturnValue
-    Builder key(ContentKey key);
+    Builder operationType(CatalogOperationType type);
+
+    @CanIgnoreReturnValue
+    Builder contentKey(ContentKey key);
 
     @CanIgnoreReturnValue
-    Builder type(Content.Type type);
+    Builder contentType(Content.Type type);
 
     @CanIgnoreReturnValue
     Builder warehouse(String warehouse);