Do not emit an empty ol tag when there are no breadcrumbs

Author: corylown

app/components/arclight/breadcrumb_component.rb

@@ -12,12 +12,8 @@ def initialize(document:, count: nil, offset: 0)
     end
 
     def call
-      breadcrumb_links = components.drop(@offset)
+      return unless breadcrumb_links.any?
 
-      if @count && breadcrumb_links.length > @count
-        breadcrumb_links = breadcrumb_links.first(@count)
-        breadcrumb_links << tag.li('&hellip;'.html_safe, class: 'breadcrumb-item')
-      end
       tag.ol class: 'breadcrumb' do
         safe_join(breadcrumb_links)
       end
@@ -36,5 +32,19 @@ def components
     def build_repository_link
       render Arclight::RepositoryBreadcrumbComponent.new(document: @document)
     end
+
+    private
+
+    def breadcrumb_links
+      @breadcrumb_links ||= limit_breadcrumb_links(components.drop(@offset))
+    end
+
+    def limit_breadcrumb_links(links)
+      return links unless @count && links.length > @count
+
+      limited_links = links.first(@count)
+      limited_links << tag.li('&hellip;'.html_safe, class: 'breadcrumb-item')
+      limited_links
+    end
   end
 end

spec/components/arclight/breadcrumb_component_spec.rb

@@ -51,6 +51,14 @@
     end
   end
 
+  context 'with an offset that removes all links' do
+    let(:attr) { { offset: 4 } }
+
+    it 'does not render an empty ordered list' do
+      expect(rendered).to have_no_selector 'ol'
+    end
+  end
+
   it 'renders breadcrumb links' do
     expect(rendered).to have_css 'li', text: 'my repository'
     expect(rendered).to have_link 'DEF', href: '/catalog/abc123_def'