Do not process test step commands

These should not be processed since any variable substitution should be
handled by env.

Also to note: This use of arg expansion was causing tests to fail,
though we didn't see it due to some issues with CI infra.

Signed-off-by: Brian Goff <[email protected]>

Author: cpuguy83

load_test.go

@@ -732,7 +732,7 @@ tests: &tests
         starts_with: ${SOME_ARG}
         ends_with: ${SOME_ARG}
     steps:
-      - command: ${SOME_ARG}
+      - command: hello
         stdout: *check-output
         stderr: *check-output
         stdin: ${SOME_ARG}
@@ -844,7 +844,6 @@ targets:
 		assert.Check(t, cmp.Equal(spec.Tests[0].Steps[0].Stderr.Contains[0], "test"))
 		assert.Check(t, cmp.Equal(spec.Tests[0].Steps[0].Stderr.StartsWith, "test"))
 		assert.Check(t, cmp.Equal(spec.Tests[0].Steps[0].Stderr.EndsWith, "test"))
-		assert.Check(t, cmp.Equal(spec.Tests[0].Steps[0].Command, "test"))
 
 		assert.Check(t, cmp.Equal(spec.PackageConfig.Signer.Args["FOO"], "test"))
 
@@ -873,7 +872,6 @@ targets:
 		assert.Check(t, cmp.Equal(target.Tests[0].Steps[0].Stderr.Contains[0], "test"))
 		assert.Check(t, cmp.Equal(target.Tests[0].Steps[0].Stderr.StartsWith, "test"))
 		assert.Check(t, cmp.Equal(target.Tests[0].Steps[0].Stderr.EndsWith, "test"))
-		assert.Check(t, cmp.Equal(target.Tests[0].Steps[0].Command, "test"))
 
 		assert.Check(t, cmp.Equal(target.Dependencies.ExtraRepos[0].Keys["img"].DockerImage.Cmd.Env["TEST"], "test"))
 		assert.Check(t, cmp.Equal(target.Dependencies.ExtraRepos[0].Keys["git"].Git.URL, "https://test"))

test/azlinux_test.go

@@ -2136,7 +2136,7 @@ func testLinuxPackageTestsFail(ctx context.Context, t *testing.T, cfg testLinuxC
 							Command: "/bin/sh -c 'test -d /mount1'",
 						},
 						{
-							Command: `/bin/sh -c 'grep "some file" /mont1/some_file'`,
+							Command: `/bin/sh -c 'grep "some file" /mount1/some_file'`,
 						},
 						{
 							Command: "/bin/sh -c 'test -f /mount2'",

tests.go

@@ -187,14 +187,6 @@ func (s *TestStep) processBuildArgs(lex *shell.Lex, args map[string]string, allo
 	}
 	s.Stderr = stderr
 
-	updated, err = expandArgs(lex, s.Command, args, allowArg)
-	if err != nil {
-		appendErr(errors.Wrap(err, "command"))
-	}
-	if updated != s.Command {
-		s.Command = updated
-	}
-
 	return goerrors.Join(errs...)
 }