Merge pull request php-telegram-bot#12 from noplanman/harden_tests

Check log file for correct contents.

Author: MBoretto

tests/TestHelpers.php

@@ -53,7 +53,7 @@ class TestHelpers
     /**
      * Set the value of a private/protected property of an object
      *
-     * @param object $object   Object that contains the private property
+     * @param object $object   Object that contains the property
      * @param string $property Name of the property who's value we want to set
      * @param mixed  $value    The value to set to the property
      */
@@ -65,6 +65,20 @@ public static function setObjectProperty($object, $property, $value)
         $ref_property->setValue($object, $value);
     }
 
+    /**
+     * Set the value of a private/protected static property of a class
+     *
+     * @param string $class    Class that contains the static property
+     * @param string $property Name of the property who's value we want to set
+     * @param mixed  $value    The value to set to the property
+     */
+    public static function setStaticProperty($class, $property, $value)
+    {
+        $ref_property = new \ReflectionProperty($class, $property);
+        $ref_property->setAccessible(true);
+        $ref_property->setValue(null, $value);
+    }
+
     /**
      * Return a simple fake Update object
      *

tests/Unit/TelegramLogExternalTest.php

@@ -10,9 +10,12 @@
 
 namespace Tests\Unit;
 
+use Longman\TelegramBot\Exception\TelegramLogException;
 use Longman\TelegramBot\TelegramLog;
+use Monolog\Handler\StreamHandler;
+use Monolog\Logger;
+use Tests\TestHelpers;
 
-use Longman\TelegramBot\Exception\TelegramLogException;
 /**
  * @package         TelegramTest
  * @author          Avtandil Kikabidze <[email protected]>
@@ -22,12 +25,34 @@
  */
 class TelegramLogTest extends TestCase
 {
+    /**
+     * Logfile paths
+     */
+    private $logfiles = [
+        'error'    => '/tmp/errorlog.log',
+        'debug'    => '/tmp/debuglog.log',
+        'update'   => '/tmp/updatelog.log',
+        'external' => '/tmp/externallog.log',
+    ];
 
     /**
-    * setUp
-    */
+     * setUp
+     */
     protected function setUp()
     {
+        // Make sure no monolog instance is set before each test.
+        TestHelpers::setStaticProperty('Longman\TelegramBot\TelegramLog', 'monolog', null);
+    }
+
+    /**
+     * tearDown
+     */
+    protected function tearDown()
+    {
+        // Make sure no logfiles exist.
+        foreach ($this->logfiles as $file) {
+            file_exists($file) && unlink($file);
+        }
     }
 
     /**
@@ -62,37 +87,59 @@ public function newInstanceWithoutUpdatePath()
      */
     public function testErrorStream()
     {
-        $file = '/tmp/errorlog.log';
+        $file = $this->logfiles['error'];
         $this->assertFalse(file_exists($file));
         TelegramLog::initErrorLog($file);
         TelegramLog::error('my error');
         $this->assertTrue(file_exists($file));
-        unlink($file);
+        $this->assertContains('bot_log.ERROR: my error', file_get_contents($file));
     }
 
     /**
      * @test
      */
     public function testDebugStream()
     {
-        $file = '/tmp/debuglog.log';
+        $file = $this->logfiles['debug'];
         $this->assertFalse(file_exists($file));
         TelegramLog::initDebugLog($file);
         TelegramLog::debug('my debug');
         $this->assertTrue(file_exists($file));
-        unlink($file);
+        $this->assertContains('bot_log.DEBUG: my debug', file_get_contents($file));
     }
 
     /**
      * @test
      */
     public function testUpdateStream()
     {
-        $file = '/tmp/updatelog.log';
+        $file = $this->logfiles['update'];
         $this->assertFalse(file_exists($file));
         TelegramLog::initUpdateLog($file);
         TelegramLog::update('my update');
         $this->assertTrue(file_exists($file));
-        unlink($file);
+        $this->assertContains('my update', file_get_contents($file));
+    }
+
+    /**
+     * @test
+     */
+    public function testExternalStream()
+    {
+        $file = $this->logfiles['external'];
+        $this->assertFalse(file_exists($file));
+
+        $external_monolog = new Logger('bot_update_log');
+        $external_monolog->pushHandler(new StreamHandler($file, Logger::ERROR));
+        $external_monolog->pushHandler(new StreamHandler($file, Logger::DEBUG));
+
+        TelegramLog::initialize($external_monolog);
+        TelegramLog::error('my error');
+        TelegramLog::debug('my debug');
+
+        $this->assertTrue(file_exists($file));
+        $file_contents = file_get_contents($file);
+        $this->assertContains('bot_update_log.ERROR: my error', $file_contents);
+        $this->assertContains('bot_update_log.DEBUG: my debug', $file_contents);
     }
 }