Skip to content

Download fails silently when logged out #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eyaler opened this issue Jun 5, 2025 · 3 comments · May be fixed by #3514
Open

Download fails silently when logged out #3511

eyaler opened this issue Jun 5, 2025 · 3 comments · May be fixed by #3514
Assignees
@yugalkaushik
Labels
Bug Error or unexpected behaviors Good Medium Issue A moderately complex issue for contributors with some experience Ready for Work Issue is ready for development work

Comments

@eyaler
Copy link

eyaler commented Jun 5, 2025

p5.js version

n/a

What is your operating system?

Windows

Web browser and version

firefox 139 / edge 136

Actual Behavior

nothing happens

Expected Behavior

if downloading is not allowed the option should be greyed out or better there should be a modal popup indicating what is the issue

Steps to reproduce

file->download a user's sketch when logged out
@eyaler eyaler added Bug Error or unexpected behaviors Awaiting Maintainer Approval Needs review from a maintainer before moving forward labels Jun 5, 2025
@raclim raclim added Good Medium Issue A moderately complex issue for contributors with some experience Ready for Work Issue is ready for development work and removed Awaiting Maintainer Approval Needs review from a maintainer before moving forward labels Jun 5, 2025
@yugalkaushik
Copy link
Contributor

@raclim Can I work on this issue?

@raclim raclim assigned raclim and yugalkaushik and unassigned raclim Jun 6, 2025
@raclim
Copy link
Collaborator

raclim commented Jun 6, 2025

@yugalkaushik yes please feel free to go ahead! :)

@yugalkaushik yugalkaushik linked a pull request Jun 6, 2025 that will close this issue
Open
4 tasks
@yugalkaushik
Copy link
Contributor

@eyaler @raclim I added a tooltip, since a popup can't be linked to the unauthenticated download button because nav buttons are disabled by default when the user isn't logged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yugalkaushik yugalkaushik

Labels
Bug Error or unexpected behaviors Good Medium Issue A moderately complex issue for contributors with some experience Ready for Work Issue is ready for development work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tooltip for unauthenticated download button yugalkaushik/p5.js-web-editor
3 participants
@eyaler @raclim @yugalkaushik