fix: 'Outdated docs' banner flash & simplify guide check

rschristian · rschristian · commit 5ea15cef6a2e · 2024-04-08T04:40:02.000-05:00
diff --git a/content/de/index.md b/content/de/index.md
@@ -1,7 +1,6 @@
 ---
 layout: home
 title: Preact
-toc: false
 ---
 
 
diff --git a/content/en/index.md b/content/en/index.md
@@ -1,7 +1,6 @@
 ---
 layout: home
 title: Preact
-toc: false
 description: 'Fast 3kB alternative to React with the same modern API.'
 ---
 
diff --git a/content/es/index.md b/content/es/index.md
@@ -1,7 +1,6 @@
 ---
 layout: home
 title: Preact
-toc: false
 ---
 
 
diff --git a/content/fr/index.md b/content/fr/index.md
@@ -1,7 +1,6 @@
 ---
 layout: home
 title: Preact
-toc: false
 ---
 
 <jumbotron>
diff --git a/content/it/index.md b/content/it/index.md
@@ -1,7 +1,6 @@
 ---
 layout: home
 title: Preact
-toc: false
 ---
 
 
diff --git a/content/ja/index.md b/content/ja/index.md
@@ -1,7 +1,6 @@
 ---
 layout: home
 title: Preact
-toc: false
 description: 'Preact is a fast 3kB alternative to React with the same modern API'
 ---
 
diff --git a/content/kr/index.md b/content/kr/index.md
@@ -1,7 +1,6 @@
 ---
 layout: home
 title: Preact
-toc: false
 description: 'Fast 3kB alternative to React with the same modern API.'
 ---
 
diff --git a/content/pt-br/index.md b/content/pt-br/index.md
@@ -1,7 +1,6 @@
 ---
 layout: home
 title: Preact
-toc: false
 ---
 
 
diff --git a/content/ru/index.md b/content/ru/index.md
@@ -1,7 +1,6 @@
 ---
 layout: home
 title: Preact
-toc: false
 description: 'Быстрая 3КБ-альтернатива React с тем же современным API.'
 ---
 
diff --git a/content/tr/index.md b/content/tr/index.md
@@ -1,7 +1,6 @@
 ---
 layout: home
 title: Preact
-toc: false
 ---
 
 
diff --git a/content/zh/index.md b/content/zh/index.md
@@ -1,7 +1,6 @@
 ---
 layout: home
 title: Preact
-toc: false
 description: 'React 的 3kb 轻量级替代方案，拥有相同的现代 API。'
 ---
 
diff --git a/src/components/controllers/doc-page.jsx b/src/components/controllers/doc-page.jsx
@@ -4,12 +4,12 @@ import { useTitle, useDescription } from './utils';
 import config from '../../config.json';
 import { NotFound } from './not-found';
 import cx from '../../lib/cx';
-import { LATEST_MAJOR, isDocPage } from '../../lib/docs';
 import { useLanguage } from '../../lib/i18n';
 import { MarkdownRegion } from './markdown-region';
 import Sidebar from '../sidebar';
 import Footer from '../footer/index';
 import { docRoutes } from '../../lib/route-utils';
+import { LATEST_MAJOR } from '../doc-version';
 import style from './style.module.css';
 
 export function DocPage() {
@@ -20,29 +20,27 @@ export function DocPage() {
 		return <NotFound />;
 	}
 
-	return <DocLayout />;
+	return <DocLayout isGuide />;
 }
 
-export function DocLayout() {
+export function DocLayout({ isGuide = false }) {
 	const { path } = useLocation();
 	const [lang] = useLanguage();
 
 	const { html, meta } = useContent([lang, path === '/' ? 'index' : path]);
 	useTitle(meta.title);
 	useDescription(meta.description);
 
-	const hasSidebar = meta.toc !== false && isDocPage(path);
-
 	return (
-		<div class={cx(style.page, hasSidebar && style.withSidebar)}>
+		<div class={cx(style.page, isGuide && style.withSidebar)}>
 			<div class={style.outer}>
-				{hasSidebar && (
+				{isGuide && (
 					<div class={style.sidebarWrap}>
 						<Sidebar />
 					</div>
 				)}
 				<div class={style.inner}>
-					<OldDocsWarning />
+					{isGuide && <OldDocsWarning />}
 					<MarkdownRegion html={html} meta={meta} />
 					<Footer />
 				</div>
@@ -53,9 +51,8 @@ export function DocLayout() {
 
 function OldDocsWarning() {
 	const { name, version } = useRoute().params;
-	const { path } = useLocation();
 
-	if (!isDocPage(path) || version === LATEST_MAJOR) {
+	if (version === LATEST_MAJOR) {
 		return null;
 	}
 
diff --git a/src/components/doc-version/index.jsx b/src/components/doc-version/index.jsx
@@ -3,7 +3,8 @@ import { useLocation, useRoute } from 'preact-iso';
 import config from '../../config.json';
 import style from './style.module.css';
 
-export const AVAILABLE_DOCS = [10, 8];
+export const LATEST_MAJOR = 'v10';
+export const AVAILABLE_DOCS = ['10', '8'];
 
 /**
  * Select box to switch the currently displayed docs version
@@ -28,7 +29,7 @@ export default function DocVersion() {
 			Version:{' '}
 			<select value={version} class={style.select} onChange={onChange}>
 				{AVAILABLE_DOCS.map(v => {
-					const suffix = v === 10 ? ' (current)' : '';
+					const suffix = LATEST_MAJOR.slice(1) == v ? ' (current)' : '';
 					return (
 						<option key={v} value={`v${v}`}>
 							{v}.x{suffix}
diff --git a/src/lib/docs.js b/src/lib/docs.js
