refetchOnWindowFocus doesn't act as a reactive

[Shedevro]

I'm conditionally passing refetchOnWindowFocus and refetchOnReconnect as () => true or () => false.
And if I focus the page it still loads data.
An additional check is required inside useEventListener to see if refetchOnWindowFocus/refetchOnReconnect doesn't actually return false.
Thanks!

[posva]

You probably need to move the condition within the function. Otherwise you are always passing a function what always returns false or always returns true

[Shedevro]

@posva I'm using defineColadaLoader and when I activate the route it fetches data on window focus - this is correct.
But when I go away from this route the loader continues data fetching on window focus.
I've resolved this by doing:

<script lang="ts">
const isRouteActivated = ref(false);

export const loader = defineColadaLoader('', {
  ...
  refetchOnReconnect: isRouteActivated,
  refetchOnWindowFocus: isRouteActivated,
});
</scrip>

<script setup lang="ts">
  onMounted(() => {
    isRouteActivated.value = true;
  });

  onUnmounted(() => {
    isRouteActivated.value = false;
  });
</scrip>

And I've patched useQuery()

  if (IS_CLIENT) {
    if (refetchOnWindowFocus) {
      useEventListener(document, "visibilitychange", () => {
        if (!toValue2(refetchOnWindowFocus)) { // <-- HERE
          return;
        }
        if (document.visibilityState === "visible" && toValue2(enabled)) {
          if (toValue2(refetchOnWindowFocus) === "always") {
            refetch();
          } else {
            refresh();
          }
        }
      });
    }

[posva]

That is indeed a bug. It's fixed and released