Remove Format Document from the Editor Action Bar (#8196)

Addresses #8189 by removing the Format Document action from the Editor Action Bar.

Author: softwarenerd

src/vs/workbench/browser/parts/editor/editorActionBarControl.tsx

@@ -101,7 +101,6 @@ export class EditorActionBarControl extends Disposable {
 		// Create the editor action bar factory.
 		const editorActionBarFactory = this._register(new EditorActionBarFactory(
 			this._editorGroup,
-			this._commandService,
 			this._contextKeyService,
 			this._keybindingService,
 			this._menuService,

src/vs/workbench/browser/parts/editor/editorActionBarFactory.tsx

@@ -11,16 +11,13 @@ import { localize } from '../../../../nls.js';
 import { IEditorGroupView } from './editor.js';
 import { Emitter } from '../../../../base/common/event.js';
 import { ThemeIcon } from '../../../../base/common/themables.js';
-import { ICommandService } from '../../../../platform/commands/common/commands.js';
-import { EditorContextKeys } from '../../../../editor/common/editorContextKeys.js';
 import { Disposable, DisposableStore } from '../../../../base/common/lifecycle.js';
 import { IAction, Separator, SubmenuAction } from '../../../../base/common/actions.js';
 import { actionTooltip } from '../../../../platform/positronActionBar/common/helpers.js';
 import { IKeybindingService } from '../../../../platform/keybinding/common/keybinding.js';
+import { IContextKeyService } from '../../../../platform/contextkey/common/contextkey.js';
 import { PositronActionBar } from '../../../../platform/positronActionBar/browser/positronActionBar.js';
-import { ContextKeyExpr, IContextKeyService } from '../../../../platform/contextkey/common/contextkey.js';
 import { ActionBarRegion } from '../../../../platform/positronActionBar/browser/components/actionBarRegion.js';
-import { ActionBarButton } from '../../../../platform/positronActionBar/browser/components/actionBarButton.js';
 import { ActionBarSeparator } from '../../../../platform/positronActionBar/browser/components/actionBarSeparator.js';
 import { ActionBarMenuButton } from '../../../../platform/positronActionBar/browser/components/actionBarMenuButton.js';
 import { ActionBarActionButton } from '../../../../platform/positronActionBar/browser/components/actionBarActionButton.js';
@@ -37,14 +34,6 @@ const PADDING_RIGHT = 8;
 /**
  * Localized strings.
  */
-const positronFormatDocumentAriaLabel = localize(
-	'positronFormatDocumentAriaLabel',
-	"Format Document"
-);
-const positronFormatDocumentTooltip = localize(
-	'positronFormatDocumentTooltip',
-	"Format Document"
-);
 const positronMoveIntoNewWindowAriaLabel = localize(
 	'positronMoveIntoNewWindowAriaLabel',
 	"Move into new window"
@@ -77,15 +66,6 @@ interface SubmenuDescriptor {
 export class EditorActionBarFactory extends Disposable {
 	//#region Private Properties
 
-	/**
-	 * The context key expression for showing the format document action.
-	 */
-	private readonly _showFormatDocumentContextKeyExpr = ContextKeyExpr.and(
-		EditorContextKeys.notInCompositeEditor,
-		EditorContextKeys.writable,
-		EditorContextKeys.hasDocumentFormattingProvider
-	);
-
 	/**
 	 * Gets the menu disposable stores.
 	 */
@@ -131,14 +111,12 @@ export class EditorActionBarFactory extends Disposable {
 	/**
 	 * Constructor.
 	 * @param _editorGroup The editor group.
-	 * @param _commandService The command service.
 	 * @param _contextKeyService The context key service.
 	 * @param _keybindingService The keybinding service.
 	 * @param _menuService The menu service.
 	 */
 	constructor(
 		private readonly _editorGroup: IEditorGroupView,
-		private readonly _commandService: ICommandService,
 		private readonly _contextKeyService: IContextKeyService,
 		private readonly _keybindingService: IKeybindingService,
 		private readonly _menuService: IMenuService,
@@ -181,35 +159,23 @@ export class EditorActionBarFactory extends Disposable {
 		// Create the set of processed actions.
 		const processedActions = new Set<string>();
 
-		// Create the left action bar elements from the editor title menu's EditorTitleRun action.
-		const leftActionBarElements = this.buildActionBarElements(
-			processedActions,
-			false,
-			MenuId.EditorTitle,
-			new Set(['submenuitem.EditorTitleRun']),
-		);
-
-		// Append the format document action to the left action bar elements, if applicable.
-		const activeEditorContextKeyService = this._editorGroup.activeEditorPane?.scopedContextKeyService;
-		if (activeEditorContextKeyService && activeEditorContextKeyService.contextMatchesRules(this._showFormatDocumentContextKeyExpr)) {
-			leftActionBarElements.push(
-				<ActionBarButton
-					ariaLabel={positronFormatDocumentAriaLabel}
-					icon={ThemeIcon.fromId('positron-format-document')}
-					tooltip={positronFormatDocumentTooltip}
-					onPressed={() => {
-						this._commandService.executeCommand('editor.action.formatDocument');
-					}}
-				/>
-			);
-		}
-
-		// Append the editor actions left menu's EditorActionsLeft action to the left action bar elements.
-		leftActionBarElements.push(...this.buildActionBarElements(
-			processedActions,
-			false,
-			MenuId.EditorActionsLeft,
-		));
+		// Create the left action bar elements from the editor title menu's editor title run submenu
+		// item and the editor actions left menu.
+		const leftActionBarElements = [
+			// Build action bar elements from the editor title run submenu item.
+			...this.buildActionBarElements(
+				processedActions,
+				false,
+				MenuId.EditorTitle,
+				new Set(['submenuitem.EditorTitleRun']),
+			),
+			// Build action bar elements from the editor actions left menu.
+			...this.buildActionBarElements(
+				processedActions,
+				false,
+				MenuId.EditorActionsLeft,
+			)
+		];
 
 		// Build the right action bar elements from the editor actions right menu and the remaining
 		// actions on the editor title menu.