Skip to content

Commit b4bedb2

Browse files
committed
improve logging performance to satisfy linter
1 parent ed39e64 commit b4bedb2

File tree

1 file changed

+16
-9
lines changed
  • extensions/positron-python/python_files/posit/positron

1 file changed

+16
-9
lines changed

extensions/positron-python/python_files/posit/positron/variables.py

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -769,21 +769,28 @@ def _summarize_data(self, path: list[str]):
769769
)
770770

771771
profiles = []
772+
skipped_columns = []
772773
for i, column in enumerate(schema.columns):
774+
summary_stats = None
773775
try:
774776
summary_stats = table_view._prof_summary_stats(i, format_options) # noqa: SLF001
775-
profiles.append(
776-
{
777-
"column_name": column.column_name,
778-
"type_display": column.type_display,
779-
"summary_stats": summary_stats,
780-
}
781-
)
782777
except Exception as e:
783-
# Skip columns that can't be summarized
784-
logger.warning(f"Skipping summary stats for column {i} ({column.column_name}): {e}")
778+
# Collect failed columns for later logging
779+
skipped_columns.append((i, column.column_name, e))
785780
continue
786781

782+
profiles.append(
783+
{
784+
"column_name": column.column_name,
785+
"type_display": column.type_display,
786+
"summary_stats": summary_stats,
787+
}
788+
)
789+
790+
# Log all skipped columns at once
791+
for i, column_name, error in skipped_columns:
792+
logger.warning(f"Skipping summary stats for column {i} ({column_name}): {error}")
793+
787794
self._send_result(
788795
{
789796
"schema": {

0 commit comments

Comments
 (0)