review changes

Author: timtmok

src/vs/workbench/contrib/positronPlots/browser/components/plotsContainer.tsx

@@ -39,7 +39,6 @@ interface PlotContainerProps {
 	visible: boolean;
 	showHistory: boolean;
 	darkFilterMode: DarkFilter;
-	zoom: number;
 }
 
 /**

src/vs/workbench/contrib/positronPlots/browser/positronPlots.tsx

@@ -181,7 +181,7 @@ export const PositronPlots = (props: PropsWithChildren<PositronPlotsProps>) => {
 				width={width}
 				x={posX}
 				y={posY}
-				zoom={zoom} />
+			/>
 		</PositronPlotsContextProvider>
 	);
 

src/vs/workbench/contrib/positronPlots/browser/positronPlotsService.ts

@@ -912,7 +912,8 @@ export class PositronPlotsService extends Disposable implements IPositronPlotsSe
 				StorageScope.WORKSPACE);
 		}));
 		this._register(plot.onDidChangeZoomLevel((zoomLevel) => {
-			// Store the zoom level in the plot metadata
+			// Update the stored metadata with the new zoom level
+			plot.metadata.zoom_level = zoomLevel;
 			this.storePlotMetadata(plot.metadata);
 		}));
 		this._editorPlots.set(metadata.id, plot);

src/vs/workbench/contrib/positronPlotsEditor/browser/positronPlotsEditor.tsx

@@ -62,7 +62,7 @@ export class PositronPlotsEditor extends EditorPane implements IPositronPlotsEdi
 
 	private readonly _onFocusedEmitter = this._register(new Emitter<void>());
 	private _plotClient: IPositronPlotClient | undefined;
-	_zoomContextKey: IContextKey<string>;
+	private _zoomContextKey: IContextKey<string>;
 
 	get identifier(): string | undefined {
 		return this._identifier;
@@ -191,14 +191,14 @@ export class PositronPlotsEditor extends EditorPane implements IPositronPlotsEdi
 		}
 
 		this.renderContainer(this._plotClient);
-		this.onSizeChanged((event: ISize) => {
+		this._register(this.onSizeChanged((event: ISize) => {
 			this._height = event.height;
 			this._width = event.width;
 
 			if (this._plotClient) {
 				this.renderContainer(this._plotClient);
 			}
-		});
+		}));
 	}
 
 	override layout(dimension: DOM.Dimension): void {

src/vs/workbench/services/languageRuntime/common/languageRuntimePlotClient.ts

@@ -470,7 +470,6 @@ export class PlotClientInstance extends Disposable implements IPositronPlotClien
 
 	set zoomLevel(level: ZoomLevel) {
 		if (this.metadata.zoom_level !== level) {
-			this.metadata.zoom_level = level;
 			this._zoomLevelEmitter.fire(level);
 		}
 	}

src/vs/workbench/services/positronPlots/common/staticPlotClient.ts

@@ -85,7 +85,6 @@ export class StaticPlotClient extends Disposable implements IPositronPlotClient,
 	}
 
 	set zoomLevel(zoom: ZoomLevel) {
-		this.metadata.zoom_level = zoom;
 		this._zoomLevelEventEmitter.fire(zoom);
 	}