Skip to content

Deprecate allow_missing_columns: bool in favor of missing_columns: Literal["insert", "raise"] #21997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nameexhaustion opened this issue Mar 31, 2025 · 1 comment · May be fixed by #22784
Open

Deprecate allow_missing_columns: bool in favor of missing_columns: Literal["insert", "raise"] #21997

nameexhaustion opened this issue Mar 31, 2025 · 1 comment · May be fixed by #22784
Assignees
@nameexhaustion
Labels
A-api Area: changes to the public API enhancement New feature or an improvement of an existing feature
Milestone
2.0.0

Comments

@nameexhaustion
Copy link
Collaborator

Description

The latter is much more descriptive in code of what this parameter will actually do.
@nameexhaustion nameexhaustion added the enhancement New feature or an improvement of an existing feature label Mar 31, 2025
@nameexhaustion nameexhaustion added this to the 2.0.0 milestone Mar 31, 2025
@nameexhaustion nameexhaustion added the A-api Area: changes to the public API label Mar 31, 2025
@coastalwhite
Copy link
Collaborator

I think one prerequisite for this is the dispatching of all multiscanning to the new streaming engine for that part of the query. I really don't want to have to implement this behavior for every reader individually.

@nameexhaustion nameexhaustion self-assigned this Apr 11, 2025
@nameexhaustion nameexhaustion changed the title Deprecate allow_missing_columns: bool in favor of missing_columns: Literal["fill", "raise] Deprecate allow_missing_columns: bool in favor of missing_columns: Literal["fill", "raise"] Apr 15, 2025
@nameexhaustion nameexhaustion changed the title Deprecate allow_missing_columns: bool in favor of missing_columns: Literal["fill", "raise"] Deprecate allow_missing_columns: bool in favor of missing_columns: Literal["insert", "raise"] Apr 15, 2025
@nameexhaustion nameexhaustion linked a pull request May 16, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nameexhaustion nameexhaustion

Labels
A-api Area: changes to the public API enhancement New feature or an improvement of an existing feature
Projects
None yet
Milestone
2.0.0
2 participants
@coastalwhite @nameexhaustion