Is send(_:while:) still relevant?

[davdroman]

I noticed the send(_:while:) method on ViewStore is not deprecated, however if memory serves it was introduced before the recent Concurrency changes.

Is there a reason to keep this method around now that we can call send with .finish()?

[stephencelis]

@davdroman We think having an alternate convenience method for driving async off state can still be useful, though we're open to discussing further if folks feel like slimming the public API down would be helpful, especially for 1.0.

[davdroman]

Personally I think it could be misconstrued as an Effect.run-compatible API, which is not.

In fact just the other day I tried using it with an action that returned a .run effect, resulting in a crash, which is actually what has led me to open this discussion.

[jshier]

There shouldn't be any issue with Effect.run. We use it with that just fine, to drive loading indicators during network requests. send(_:while:) is actually one of the great TCA conveniences that nicely demonstrates the "magic" the framework enables.

[davdroman]

Is that so? My mistake then! It's quite strange, I got an EXC_BAD_ACCESS. It must've been something else I guess.

[stephencelis]

@davdroman Think you can repro? That definitely sounds strange so if we have a bug we should def look into it!