AccessibilityIdentifier being overwritten in form by confirmation dialog

[kgrigsby59]

Describe the bug
I'm trying to assign an accessibilityIdentifier to a form and to a confirmationDialog defined at the same level. It appears the confirmationDialog identifier is overwriting the identifier of the form. I'm guessing some support needs to be added to ConfirmationDialogState.

To Reproduce
IDTest.zip

There is a ui test asserting both exist but it fails.

    var body: some View {
        NavigationView {
            WithViewStore(store) { viewStore in
                Form {
                    Button("Confirmation Dialog") { viewStore.send(.confirmationDialogButtonTapped) }
                }
                .accessibilityIdentifier("MyForm")

                .confirmationDialog(
                    store.scope(state: \.confirmationDialog),
                    dismiss: .confirmationDialogDismissed
                )
                .accessibilityIdentifier("MyConfirmation")
            }
        }
    }

Expected behavior
I expect the form to have an identifier "MyForm" and the confirmationDialog to have the identifier "MyIdentifier"

Environment

• swift-composable-architecture version [0.34.0]
• Xcode [13.3]
• Swift [5.6]
• OS: [iOS 15.4]

Additional context
Add any more context about the problem here.

[mbrandonw]

Can you confirm this is a TCA issue by recreating this small demo in vanilla SwiftUI and seeing if .accessibilityIdentifier works the way you expect? Since our .confirmationDialog just immediately calls to SwiftUI's, I imagine this is a problem in plain SwiftUI.

[kgrigsby59]

Yes, it fails with vanilla SwiftUi also. Am I doing something wrong?

struct ContentView: View {
    @State private var showConfirmationDialog = false

    var body: some View {
        NavigationView {
            Form {
                Button("Confirmation Dialog") { showConfirmationDialog = true }
            }
            .accessibilityIdentifier("MyForm")
            
            .confirmationDialog(
                "Confirmation dialog",
                isPresented: $showConfirmationDialog,
                actions: {
                    Button("Cancel", role: .cancel) {
                        showConfirmationDialog = false
                    }
                },
                message: {
                    Text("This is a confirmation dialog.")
                }
            )
            .accessibilityIdentifier("MyConfirmation")
        }
    }
}

Here is the output when inspecting before the confirmation dialog appears. You can see the only table identifier is "MyConfirmation"

(lldb) po app
    t =     8.29s Requesting snapshot of accessibility hierarchy for app with pid 88586
    t =     8.32s Requesting snapshot of accessibility hierarchy for app with pid 88586
Attributes: Application, 0x125d21100, pid: 88586, label: 'VanillaTestID'
Element subtree:
 →Application, 0x125d21100, pid: 88586, label: 'VanillaTestID'
    Window (Main), 0x125d37bb0, {{0.0, 0.0}, {320.0, 568.0}}
      Other, 0x125d176d0, {{0.0, 0.0}, {320.0, 568.0}}
        Other, 0x125d1eee0, {{0.0, 0.0}, {320.0, 568.0}}
          Other, 0x125d0a590, {{0.0, 0.0}, {320.0, 568.0}}
            Other, 0x125d06be0, {{0.0, 0.0}, {320.0, 568.0}}
              Other, 0x125d36470, {{0.0, 0.0}, {320.0, 568.0}}
                Other, 0x125d179b0, {{0.0, 0.0}, {320.0, 568.0}}
                  Other, 0x125d2b770, {{0.0, 0.0}, {320.0, 568.0}}
                    NavigationBar, 0x125d20160, {{0.0, 20.0}, {320.0, 91.0}}, identifier: '_TtGC7SwiftUI19UIHosting'
                      StaticText, 0x125d20270, {{16.0, 66.5}, {6.5, 36.0}}, label: ' '
                    Other, 0x125d20830, {{0.0, 0.0}, {320.0, 568.0}}
                      Other, 0x125d20940, {{0.0, 0.0}, {320.0, 568.0}}
                        Other, 0x125d1fa90, {{0.0, 0.0}, {320.0, 568.0}}
                          Other, 0x125d1fba0, {{0.0, 0.0}, {320.0, 568.0}}
                            Table, 0x125d2f2f0, {{0.0, 0.0}, {320.0, 568.0}}, identifier: 'MyConfirmation'
                              Cell, 0x125d2f400, {{0.0, 111.0}, {320.0, 44.0}}, label: 'Confirmation Dialog'
                                Other, 0x125d237a0, {{0.0, 111.0}, {320.0, 0.5}}
                                Other, 0x125d238b0, {{0.0, 111.0}, {320.0, 44.0}}
                                  Other, 0x125d1c7b0, {{0.0, 111.0}, {320.0, 44.0}}
                                Other, 0x125d1c8c0, {{0.0, 154.5}, {320.0, 0.5}}
                                Other, 0x125d228d0, {{0.0, 111.0}, {320.0, 44.0}}
                                  Other, 0x125d229e0, {{0.0, 111.0}, {320.0, 44.0}}
                                    Button, 0x125d22af0, {{0.0, 111.0}, {320.0, 44.0}}, label: 'Confirmation Dialog'
Path to element:
 →Application, 0x125d21100, pid: 88586, label: 'VanillaTestID'
Query chain:
 →Find: Target Application 'com.mac.kgrigsby.VanillaTestID'
  Output: {
    Application, 0x135d6aa10, pid: 88586, label: 'VanillaTestID'
  }

[stephencelis]

@kgrigsby59 We're not quite sure, but if it's a bug in SwiftUI you may want to file feedback to see if the behavior is intentional or not.

I'm going to convert this to a discussion since it's not a bug in our library's code, and so that others can find the information there.