Fix deprecations

Author: adangel

.github/workflows/build.yml

@@ -43,7 +43,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
 
-      - name: Run .ci/build
+      - name: Run .ci/build.sh
         run: |
           cd custom-rules/plain-java
           .ci/build.sh
@@ -54,8 +54,7 @@ jobs:
     steps:
       - uses: actions/checkout@v3
 
-      - name: Run maven
+      - name: Run .ci/build.sh
         run: |
           cd maven/simple-project
-          mvn verify | tee build.log
-          grep "You have 2 PMD violations" build.log || (echo "Missing expected rule violation"; exit 1)
+          .ci/build.sh

custom-rules/maven-java/pmd-java-custom/src/main/java/net/sourceforge/pmd/examples/java/rules/MyRule.java

@@ -2,14 +2,14 @@
 
 import net.sourceforge.pmd.lang.java.ast.ASTVariableDeclaratorId;
 import net.sourceforge.pmd.lang.java.rule.AbstractJavaRule;
-import net.sourceforge.pmd.properties.StringProperty;
+import net.sourceforge.pmd.properties.PropertyDescriptor;
+import net.sourceforge.pmd.properties.PropertyFactory;
 
 public class MyRule extends AbstractJavaRule {
 
-    private static final StringProperty BAD_NAME = StringProperty.named("badName")
+    private static final PropertyDescriptor<String> BAD_NAME = PropertyFactory.stringProperty("badName")
             .defaultValue("foo")
             .desc("The variable name that should not be used.")
-            .uiOrder(1.0f)
             .build();
 
     public MyRule() {
@@ -21,7 +21,7 @@ public MyRule() {
     public Object visit(ASTVariableDeclaratorId node, Object data) {
         String badName = getProperty(BAD_NAME);
         if (node.hasImageEqualTo(badName)) {
-            addViolation(data, node, node.getImage());
+            asCtx(data).addViolation(node, node.getName());
         }
         return data;
     }

custom-rules/maven-java/pmd-java-custom/src/main/resources/net/sourceforge/pmd/examples/java/rules/MyRule.xml

@@ -1,4 +1,4 @@
-<?xml version="1.0"?>
+<?xml version="1.0" encoding="UTF-8"?>
 
 <ruleset name="My Rule"
     xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

custom-rules/maven-java/pmd-java-custom/src/main/resources/net/sourceforge/pmd/examples/java/rules/VariableNaming.xml

@@ -1,4 +1,4 @@
-<?xml version="1.0"?>
+<?xml version="1.0" encoding="UTF-8"?>
 
 <ruleset name="VariableNamingRule"
     xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

custom-rules/maven-plsql/pmd-plsql-custom/src/main/java/net/sourceforge/pmd/examples/plsql/rules/ShortVariableRule.java

@@ -31,7 +31,7 @@ public Object visit(ASTVariableOrConstantDeclaratorId node, Object data) {
         ASTID id = node.getFirstChildOfType(ASTID.class);
         if (id != null) {
             if (node.getImage().length() < min) {
-                addViolation(data, node, node.getImage());
+                asCtx(data).addViolation(node, node.getImage());
             }
         }
         return data;

custom-rules/plain-java/src/MyRule.java

@@ -6,7 +6,7 @@ public class MyRule extends AbstractJavaRule {
     @Override
     public Object visit(ASTVariableDeclaratorId node, Object data) {
         if (node.hasImageEqualTo("foo")) {
-            addViolationWithMessage(data, node, "Avoid the identifier 'foo'.");
+            asCtx(data).addViolationWithMessage(node, "Avoid the identifier 'foo'.");
         }
         return super.visit(node, data);
     }

maven/simple-project/.ci/build.sh

@@ -0,0 +1,9 @@
+#!/bin/bash
+
+# exit immediately if a command fails
+set -e
+java -version
+mvn --version
+
+mvn verify | tee build.log
+grep "You have 2 PMD violations" build.log || (echo "Missing expected rule violation"; exit 1)

maven/simple-project/src/main/java/net/sourceforge/pmd/examples/maven/simpleproject/Main.java

@@ -1,3 +1,5 @@
+package net.sourceforge.pmd.examples.maven.simpleproject;
+
 public class Main {
 
     // UnusedPrivateField