refactor: crate names, paths, other nits (#553)

* chore: update README

* refactor: rename crates/paths

* Update lint.yaml

* fix: build

* refactor: error naming

* Update main.rs

* fix: reference to `errors` module

* feat: `udeps` in CI

* Update lint.yaml

* fix: clippy throws on warns

* fix: lint in client

* fix: lint in notary

* feat: test workflows

* add test to `web-prover.yaml`

* Update lint.yaml

* remove binstall

* fix: workflows

* Update check.yaml

* fix: release profile

Author: Autoparallel

.github/workflows/build_client_native.yaml

@@ -27,20 +27,20 @@ jobs:
           rust-cache-key: client_native
 
       - run: |
-          cargo build -p client --release
+          cargo build -p web-prover-client --release
 
       - uses: actions/upload-artifact@v4
         if: matrix.os == 'ubuntu-latest'
         with:
-          name: "client.linux.amd64"
-          path: "target/release/client"
+          name: "web-prover-client.linux.amd64"
+          path: "target/release/web-prover-client"
           retention-days: 7
           if-no-files-found: "error"
 
       - uses: actions/upload-artifact@v4
         if: matrix.os == 'macos-latest'
         with:
-          name: "client.macos.arm64"
-          path: "target/release/client"
+          name: "web-prover-client.macos.arm64"
+          path: "target/release/web-prover-client"
           retention-days: 7
           if-no-files-found: "error"

.github/workflows/build_notary.yaml

@@ -26,12 +26,12 @@ jobs:
         with:
           rust-cache-key: client_notary
 
-      - run: cargo build -p notary --release
+      - run: cargo build -p web-prover-notary --release
 
       - uses: actions/upload-artifact@v4
         if: matrix.os == 'ubuntu-latest'
         with:
           name: "notary.linux.amd64"
-          path: "target/release/notary"
+          path: "target/release/web-prover-notary"
           retention-days: 7
           if-no-files-found: "error"

.github/workflows/check.yaml

@@ -0,0 +1,56 @@
+name: Check
+
+on:
+  workflow_call:
+
+jobs:
+  check:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        check: [clippy, test, udeps]
+        crate: [web-prover-notary, web-prover-client, web-prover-core]
+        include:
+          - check: fmt
+            crate: all
+    steps:
+      - uses: actions/checkout@v4
+
+      # Setup Rust with cache key based on check type
+      - uses: ./.github/actions/setup-rust-ubuntu
+        with:
+          rust-cache-key: ${{ matrix.check }}
+
+      # Install necessary tools based on check type
+      - name: Install cargo-binstall
+        if: matrix.check == 'udeps'
+        uses: cargo-bins/cargo-binstall@main
+
+      - name: Install cargo-udeps
+        if: matrix.check == 'udeps'
+        run: cargo binstall --no-confirm cargo-udeps
+
+      - name: Install rustfmt
+        if: matrix.check == 'fmt'
+        run: rustup component add rustfmt
+
+      # Run the appropriate check
+      - name: Run clippy
+        if: matrix.check == 'clippy'
+        continue-on-error: true
+        run: cargo clippy -p ${{ matrix.crate }} -- -D warnings
+
+      - name: Run tests
+        if: matrix.check == 'test'
+        run: cargo test -p ${{ matrix.crate }}
+
+      - name: Check fmt
+        if: matrix.check == 'fmt'
+        continue-on-error: true
+        run: cargo fmt --all -- --check
+
+      - name: Check unused dependencies
+        if: matrix.check == 'udeps'
+        continue-on-error: true
+        run: cargo udeps -p ${{ matrix.crate }}

.github/workflows/lint.yaml

@@ -27,8 +27,8 @@ jobs:
         shell: bash
         run: |
           mkdir -p releases/clients
-          cp target/release/client.linux.amd64/client releases/clients/client.linux.amd64
-          cp target/release/client.macos.arm64/client releases/clients/client.macos.arm64
+          cp target/release/web-prover-client.linux.amd64/web-prover-client releases/clients/client.linux.amd64
+          cp target/release/web-prover-client.macos.arm64/web-prover-client releases/clients/client.macos.arm64
           cd releases/clients
           tar -czf client.linux.amd64.tar.gz client.linux.amd64
           rm client.linux.amd64

.github/workflows/release.yaml

@@ -1,2 +1,2 @@
-listen            ="0.0.0.0:443"
-acme_email        ="eng@pluto.xyz"
+acme_email="eng@pluto.xyz"
+listen    ="0.0.0.0:443"

.github/workflows/staging-deploy-gcs/notary-config.toml

@@ -1,3 +1,3 @@
+acme_email        ="eng@pluto.xyz"
 listen            ="0.0.0.0:443"
 notary_signing_key="/opt/notary/etc/fixture/certs/notary.key"
-acme_email        ="eng@pluto.xyz"

.github/workflows/staging-deploy/notary-config.toml

@@ -12,8 +12,8 @@ concurrency:
 
 jobs:
 
-  lint:
-    uses: ./.github/workflows/lint.yaml
+  check:
+    uses: ./.github/workflows/check.yaml
 
   build_notary:
     uses: ./.github/workflows/build_notary.yaml