Skip to content

Commit 7b202b6

Browse files
committed
add draftlog and address pr feedback
1 parent c104ed7 commit 7b202b6

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

draftlogs/6581_fix.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- fix scatter3d marker opacity when marker.opacity is set to 0 [[#6581](https://github.com/plotly/plotly.js/pull/6581)]

src/traces/scatter3d/convert.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
'use strict';
22

3-
var isNumeric = require('fast-isnumeric');
4-
53
var createLinePlot = require('../../../stackgl_modules').gl_line3d;
64
var createScatterPlot = require('../../../stackgl_modules').gl_scatter3d;
75
var createErrorBars = require('../../../stackgl_modules').gl_error3d;
@@ -405,7 +403,7 @@ proto.update = function(data) {
405403

406404
// N.B. marker.opacity must be a scalar for performance
407405
var scatterOpacity = data.opacity;
408-
if(data.marker && isNumeric(data.marker.opacity)) scatterOpacity *= data.marker.opacity;
406+
if(data.marker && data.marker.opacity !== undefined) scatterOpacity *= data.marker.opacity;
409407

410408
scatterOptions = {
411409
gl: this.scene.glplot.gl,

0 commit comments

Comments
 (0)