Skip to content

Commit 03c7be0

Browse files
authored
Merge pull request #5768 from plotly/update-opensans-fonts
Fix downloading OpenSans fonts in image test
2 parents aaf3786 + 2ea31e7 commit 03c7be0

13 files changed

+5
-20
lines changed

.circleci/config.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,17 @@ jobs:
9898
- run:
9999
name: install liberation2 fonts
100100
command: sudo apt-get install fonts-liberation2
101+
- run:
102+
name: install OpenSans fonts
103+
command: sudo apt-get install fonts-open-sans
101104
- run:
102105
name: install NotoSansCJK fonts
103106
command: sudo apt install fonts-noto-cjk
104107
- run:
105108
name: download google fonts e.g. GravitasOne, NotoSansMono, NotoSans, NotoSerif, Old_Standard_TT, PT_Sans_Narrow, Raleway and Roboto
106109
command: python3 ./.circleci/download_google_fonts.py
107110
- run:
108-
name: install OpenSans as well as downloaded google fonts
111+
name: install downloaded google fonts
109112
command: |
110113
sudo cp -r .circleci/fonts/ /usr/share/
111114
sudo fc-cache -f

.circleci/download_google_fonts.py

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -50,25 +50,6 @@ def download(repo, family, types) :
5050
]
5151
)
5252

53-
"""
54-
download(
55-
'https://github.com/googlefonts/opensans/blob/main/fonts/ttf/',
56-
'OpenSans',
57-
[
58-
'Bold',
59-
'BoldItalic',
60-
'ExtraBold',
61-
'ExtraBoldItalic',
62-
'Italic',
63-
'Light',
64-
'LightItalic',
65-
'Regular',
66-
'Semibold',
67-
'SemiboldItalic',
68-
]
69-
)
70-
"""
71-
7253
download(
7354
'https://github.com/google/fonts/blob/main/ofl/ptsansnarrow/',
7455
'PT_Sans-Narrow-Web',
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
*
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.

0 commit comments

Comments
 (0)