with() errors when supplied with a NULL value

Author: cpsievert

R/ggplotly.R

@@ -624,7 +624,11 @@ gg2list <- function(p, width = NULL, height = NULL,
           d <- expand(rng$graticule)
           d$x <- scales::rescale(d$x, rng$x_range, from = c(0, 1))
           d$y <- scales::rescale(d$y, rng$y_range, from = c(0, 1))
-          params <- with(panelGrid, list(colour = colour, size = size, linetype = linetype))
+          params <- list(
+            colour = panelGrid$colour, 
+            size = panelGrid$size, 
+            linetype = panelGrid$linetype
+          )
           grill <- geom2trace.GeomPath(d, params)
           grill$hoverinfo <- "none"
           grill$showlegend <- FALSE

tests/testthat/test-ggplot-sf.R

@@ -69,3 +69,17 @@ test_that("sf aspect ratio is correct", {
   expect_equivalent(l$layout$xaxis$scaleanchor, "y")
   expect_equal(l$layout$xaxis$scaleratio, 0.81678435872298)
 })
+
+
+test_that("works with a blank theme", {
+  skip_if_not_installed("sf")
+  
+  p <- ggplot(nc) + geom_sf() + 
+    ggthemes::theme_map()
+  
+  l <- save_outputs(p, "sf-theme-map")
+  
+  # TODO: perhaps the graticule shouldn't be included at all?
+  expect_length(l$data, 2)
+  expect_equivalent(l$data[[1]]$line$color, "transparent")
+})