Skip to content

Commit 4611808

Browse files
committed
test latest clickhouse by default, but include Plausible-specific version in the matrix
1 parent 1212a1a commit 4611808

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

.github/workflows/test.yml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,24 @@ jobs:
1616
matrix:
1717
elixir: ["1.14", "1.15", "1.16"]
1818
otp: ["25", "26"]
19-
clickhouse: ["23.3.7.5", "latest"]
19+
clickhouse: ["latest"]
2020
timezone: ["UTC"]
2121
include:
2222
- elixir: "1.16"
2323
otp: "26"
24-
clickhouse: "23.3.7.5"
24+
clickhouse: "latest"
2525
timezone: "Europe/Berlin"
26+
# Plausible
27+
# - https://github.com/plausible/analytics/blob/master/.tool-versions
28+
# - https://github.com/plausible/analytics/blob/master/.github/workflows/elixir.yml
29+
- elixir: "1.16.0"
30+
otp: "26.2.1"
31+
clickhouse: "23.3.7.5"
32+
timezone: "UTC"
2633

2734
services:
2835
clickhouse:
29-
image: clickhouse/clickhouse-server:${{ matrix.clickhouse }}-alpine
36+
image: clickhouse/clickhouse-server:${{ matrix.clickhouse }}
3037
ports:
3138
- 8123:8123
3239
env:

test/ch/connection_test.exs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1282,8 +1282,9 @@ defmodule Ch.ConnectionTest do
12821282
assert {:error, %Ch.Error{code: 81} = error} =
12831283
Ch.query(conn, "select 1 + 1", _params = [], database: "no-db")
12841284

1285-
assert Exception.message(error) =~
1286-
"Code: 81. DB::Exception: Database `no-db` doesn't exist. (UNKNOWN_DATABASE)"
1285+
assert Exception.message(error) =~ "Code: 81."
1286+
assert Exception.message(error) =~ "`no-db`"
1287+
assert Exception.message(error) =~ "(UNKNOWN_DATABASE)"
12871288
end
12881289

12891290
test "can provide custom database", %{conn: conn} do

0 commit comments

Comments
 (0)