Skip to content

inversion of RTS/CTS parameter in esp32-hal-uart.c :: uartSetPins.  #4302

Closed
@moriamoria

Description

@moriamoria

Configuration

ESP32:

PlatformIO Version latest

Description of problem

esp32-hal-uart::uartSetPins invert RTX/CTX parameter

uartSetPins (ctsPin,rtsPin) invoque uart_set_pin(ctsPin, rtsPin) but the signature of the method uses

esp_err_t uart_set_pin(... rts_io_num, cts_io_num);

void uartSetPins(uart_t* uart, int8_t rxPin, int8_t txPin, int8_t ctsPin, int8_t rtsPin)
{
...
uart_set_pin(uart->num, txPin, rxPin, ctsPin, rtsPin);
...
}

The correct code should be 👍

uart_set_pin(uart->num, txPin, rxPin, rtsPin, ctsPin); 

Regards

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions