Skip to content

Commit 374a749

Browse files
committed
clean up some unused variables and compress the minified script
1 parent e504c7a commit 374a749

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

parallax.js

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
}
2020

2121
if (!window.requestAnimationFrame)
22-
window.requestAnimationFrame = function(callback, element) {
22+
window.requestAnimationFrame = function(callback) {
2323
var currTime = new Date().getTime();
2424
var timeToCall = Math.max(0, 16 - (currTime - lastTime));
2525
var id = window.setTimeout(function() { callback(currTime + timeToCall); },
@@ -37,9 +37,6 @@
3737

3838
// Parallax Constructor
3939

40-
var $body = $('body');
41-
var $window = $(window);
42-
4340
function Parallax(element, options) {
4441
var self = this;
4542

@@ -263,19 +260,20 @@
263260
setup: function() {
264261
if (this.isReady) return;
265262

266-
$window
267-
.on('scroll.px.parallax load.px.parallax', function() {
263+
var $doc = $(document), $win = $(window);
264+
265+
$win.on('scroll.px.parallax load.px.parallax', function() {
268266
var scrollTopMax = Parallax.docHeight - Parallax.winHeight;
269267
var scrollLeftMax = Parallax.docWidth - Parallax.winWidth;
270-
Parallax.scrollTop = Math.max(0, Math.min(scrollTopMax, $window.scrollTop()));
271-
Parallax.scrollLeft = Math.max(0, Math.min(scrollLeftMax, $window.scrollLeft()));
268+
Parallax.scrollTop = Math.max(0, Math.min(scrollTopMax, $win.scrollTop()));
269+
Parallax.scrollLeft = Math.max(0, Math.min(scrollLeftMax, $win.scrollLeft()));
272270
Parallax.requestRender();
273271
})
274272
.on('resize.px.parallax load.px.parallax', function() {
275-
Parallax.winHeight = $window.height();
276-
Parallax.winWidth = $window.width();
277-
Parallax.docHeight = $(document).height();
278-
Parallax.docWidth = $(document).width();
273+
Parallax.winHeight = $win.height();
274+
Parallax.winWidth = $win.width();
275+
Parallax.docHeight = $doc.height();
276+
Parallax.docWidth = $doc.width();
279277
Parallax.isFresh = false;
280278
Parallax.requestRender();
281279
});

parallax.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)