Skip to content

Commit b25ea54

Browse files
authored
Fix prod pypi release by adjusting shared publish workflow (#180)
## Problem Prod release builds currently fail because the required prereleaseSuffix input is not being passed to the shared workflow `publish-to-pypi.yaml` This is a follow up to #178 Release from CI landed earlier today. ## Solution There's no reason for this property to be required; the bump version action correctly handles the scenario where that value is not passed. This issue causes failures like [this one](https://github.com/pinecone-io/pinecone-python-client/actions/runs/5195718175). ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [x] Infrastructure change (CI configs, etc) ## Test Plan Land and try shipping again 🤣
1 parent bb27873 commit b25ea54

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/publish-to-pypi.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ on:
2525
default: true
2626
prereleaseSuffix:
2727
description: 'Suffix to add onto the new version number in order to mark it as a prerelease. Value ignored when shipping a release that is not a prerelease.'
28-
required: true
28+
required: false
2929
type: string
3030
default: 'rc1'
3131
TWINE_REPOSITORY:

0 commit comments

Comments
 (0)