Prevent overly greedy $scope->getType() calls in Arrays*Rules

staabm · ondrejmirtes · commit fcee93ff56e1 · 2022-12-13T16:15:51.000+01:00
diff --git a/src/Rules/Arrays/OffsetAccessValueAssignmentRule.php b/src/Rules/Arrays/OffsetAccessValueAssignmentRule.php
@@ -53,7 +53,6 @@ public function processNode(Node $node, Scope $scope): array
 			$assignedValueType = $scope->getType($node);
 		}
 
-		$originalArrayType = $scope->getType($arrayDimFetch->var);
 		$arrayTypeResult = $this->ruleLevelHelper->findTypeToCheck(
 			$scope,
 			$arrayDimFetch->var,
@@ -76,6 +75,8 @@ static function (Type $varType) use ($assignedValueType): bool {
 			return [];
 		}
 
+		$originalArrayType = $scope->getType($arrayDimFetch->var);
+
 		return [
 			RuleErrorBuilder::message(sprintf(
 				'%s does not accept %s.',

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,6 @@ public function processNode(Node $node, Scope $scope): array`
`53`	`53`	`$assignedValueType = $scope->getType($node);`
`54`	`54`	`}`
`55`	`55`
`56`		`- $originalArrayType = $scope->getType($arrayDimFetch->var);`
`57`	`56`	`$arrayTypeResult = $this->ruleLevelHelper->findTypeToCheck(`
`58`	`57`	`$scope,`
`59`	`58`	`$arrayDimFetch->var,`
`@@ -76,6 +75,8 @@ static function (Type $varType) use ($assignedValueType): bool {`
`76`	`75`	`return [];`
`77`	`76`	`}`
`78`	`77`
	`78`	`+ $originalArrayType = $scope->getType($arrayDimFetch->var);`
	`79`	`+`
`79`	`80`	`return [`
`80`	`81`	`RuleErrorBuilder::message(sprintf(`
`81`	`82`	`'%s does not accept %s.',`