remove resolveWithDefaults: bare generic alias usage restores old TemplateType behavior

Author: shmax

src/PhpDoc/TypeNodeResolver.php

@@ -516,15 +516,6 @@ private function resolveIdentifierTypeNode(IdentifierTypeNode $typeNode, NameSco
 		}
 
 		if (!$nameScope->shouldBypassTypeAliases()) {
-			// Handle a generic alias referenced without type arguments.
-			// resolveWithDefaults() applies declared defaults so params with defaults are
-			// substituted, while required params remain as TemplateType placeholders
-			// (which getRawGenericTypeAliasesUsage() later detects and reports).
-			$genericAlias = $this->findGenericTypeAlias($typeNode->name, $nameScope);
-			if ($genericAlias !== null) {
-				return $genericAlias->resolveWithDefaults($this);
-			}
-
 			$typeAlias = $this->getTypeAliasResolver()->resolveTypeAlias($typeNode->name, $nameScope);
 			if ($typeAlias !== null) {
 				return $typeAlias;

src/Type/TypeAlias.php

@@ -8,7 +8,6 @@
 use PHPStan\PhpDocParser\Ast\PhpDoc\TemplateTagValueNode;
 use PHPStan\PhpDocParser\Ast\Type\IdentifierTypeNode;
 use PHPStan\PhpDocParser\Ast\Type\TypeNode;
-use PHPStan\Type\Generic\TemplateType;
 use PHPStan\Type\Generic\TemplateTypeFactory;
 use PHPStan\Type\Generic\TemplateTypeHelper;
 use PHPStan\Type\Generic\TemplateTypeMap;
@@ -113,42 +112,6 @@ public function resolveWithArgs(TypeNodeResolver $typeNodeResolver, array $args)
 		);
 	}
 
-	/**
-	 * Resolves the alias body applying default values for template params that declare one.
-	 * Template params without defaults remain as TemplateType placeholders so that callers
-	 * (e.g. MissingTypehintCheck) can detect bare generic alias usage.
-	 */
-	public function resolveWithDefaults(TypeNodeResolver $typeNodeResolver): Type
-	{
-		$baseType = $this->resolve($typeNodeResolver);
-
-		if (count($this->templateTagValueNodes) === 0) {
-			return $baseType;
-		}
-
-		// Collect default values for params that declare one.
-		$defaultsMap = [];
-		foreach ($this->templateTagValueNodes as $tvn) {
-			if ($tvn->default === null) {
-				continue;
-			}
-			$defaultsMap[$tvn->name] = $typeNodeResolver->resolve($tvn->default, $this->nameScope);
-		}
-
-		if (count($defaultsMap) === 0) {
-			return $baseType;
-		}
-
-		// Replace only TemplateType instances scoped to THIS alias that have a declared default.
-		$aliasName = $this->aliasName;
-		return TypeTraverser::map($baseType, static function (Type $type, callable $traverse) use ($defaultsMap, $aliasName): Type {
-			if ($type instanceof TemplateType && $type->getScope()->getTypeAliasName() === $aliasName && isset($defaultsMap[$type->getName()])) {
-				return $defaultsMap[$type->getName()];
-			}
-			return $traverse($type);
-		});
-	}
-
 	/**
 	 * Builds a NameScope augmented with TemplateType placeholders for each declared template param,
 	 * so the alias body can reference them (e.g. `TFilter` resolves to a TemplateType).