Test ImpossibleCheckType rules

Author: ondrejmirtes

tests/Type/BeberleiAssert/ImpossibleCheckTypeMethodCallRuleTest.php

@@ -0,0 +1,52 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\BeberleiAssert;
+
+use PHPStan\Rules\Comparison\ImpossibleCheckTypeMethodCallRule;
+use PHPStan\Rules\Rule;
+
+class ImpossibleCheckTypeMethodCallRuleTest extends \PHPStan\Testing\RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new ImpossibleCheckTypeMethodCallRule(true);
+	}
+
+	/**
+	 * @return \PHPStan\Type\MethodTypeSpecifyingExtension[]
+	 */
+	protected function getMethodTypeSpecifyingExtensions(): array
+	{
+		return [
+			new AssertionChainTypeSpecifyingExtension(),
+		];
+	}
+
+	/**
+	 * @return \PHPStan\Type\DynamicMethodReturnTypeExtension[]
+	 */
+	public function getDynamicMethodReturnTypeExtensions(): array
+	{
+		return [
+			new AssertionChainDynamicReturnTypeExtension(),
+		];
+	}
+
+	/**
+	 * @return \PHPStan\Type\DynamicStaticMethodReturnTypeExtension[]
+	 */
+	public function getDynamicStaticMethodReturnTypeExtensions(): array
+	{
+		return [
+			new AssertThatDynamicMethodReturnTypeExtension(),
+		];
+	}
+
+	public function testExtension(): void
+	{
+		self::markTestIncomplete('Does not work yet - needs to rework ImpossibleCheckType rules, dynamic return type extension now has priority when resolving return type.');
+		$this->analyse([__DIR__ . '/data/impossible-check.php'], []);
+	}
+
+}

tests/Type/BeberleiAssert/ImpossibleCheckTypeStaticMethodCallRuleTest.php

@@ -0,0 +1,40 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Type\BeberleiAssert;
+
+use PHPStan\Rules\Comparison\ImpossibleCheckTypeStaticMethodCallRule;
+use PHPStan\Rules\Rule;
+
+class ImpossibleCheckTypeStaticMethodCallRuleTest extends \PHPStan\Testing\RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new ImpossibleCheckTypeStaticMethodCallRule(true);
+	}
+
+	/**
+	 * @return \PHPStan\Type\StaticMethodTypeSpecifyingExtension[]
+	 */
+	protected function getStaticMethodTypeSpecifyingExtensions(): array
+	{
+		return [
+			new AssertTypeSpecifyingExtension(),
+		];
+	}
+
+	public function testExtension(): void
+	{
+		$this->analyse([__DIR__ . '/data/impossible-static-check.php'], [
+			[
+				'Call to static method Assert\Assertion::string() with string will always evaluate to true.',
+				12,
+			],
+			[
+				'Call to static method Assert\Assertion::allString() with array<string> will always evaluate to true.',
+				14,
+			],
+		]);
+	}
+
+}

tests/Type/BeberleiAssert/data/impossible-check.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace ImpossibleCheck;
+
+use Assert\Assert;
+
+class Bar
+{
+
+	public function doBar(string $s)
+	{
+		Assert::that($s)->string();
+
+		/** @var string[] $strings */
+		$strings = doFoo();
+		Assert::that($strings)->all()->string();
+	}
+
+}

tests/Type/BeberleiAssert/data/impossible-static-check.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace ImpossibleCheck;
+
+use Assert\Assertion;
+
+class Foo
+{
+
+	public function doFoo(string $a, array $b)
+	{
+		Assertion::string($a);
+		Assertion::allString($b);
+		Assertion::allString($b);
+	}
+
+}