Update zlib test to use separate file for flock() #20351
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent the nightly failures that fail with permission denied on platforms with mandatory locks.
iluuu1994
approved these changes
Oct 31, 2025
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
To fully avoid this issue in CI such fixes should be backported to security branches. I realize you might not have the permission to do so, you can ping me to merge them.
Member
Author
Right I'll do that after CI passed.
No, I do have the permissions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent the nightly failures that fail with permission denied on platforms with mandatory locks.