Remove nonsensical code from odbc_execute() (#18767)

nielsdos · web-flow · commit 7f9146201930 · 2025-06-04T23:18:48.000+02:00
strlen() operates on NUL-terminated strings, writing a NUL byte at the
strlen offset accomplishes nothing but wasting cycles.
diff --git a/ext/odbc/php_odbc.c b/ext/odbc/php_odbc.c
@@ -1068,7 +1068,6 @@ PHP_FUNCTION(odbc_execute)
 					RETURN_FALSE;
 				}
 				filename = estrndup(&ZSTR_VAL(tmpstr)[1], ZSTR_LEN(tmpstr) - 2);
-				filename[strlen(filename)] = '\0';
 
 				/* Check the basedir */
 				if (php_check_open_basedir(filename)) {

Original file line number	Diff line number	Diff line change
`@@ -1068,7 +1068,6 @@ PHP_FUNCTION(odbc_execute)`
`1068`	`1068`	`RETURN_FALSE;`
`1069`	`1069`	`}`
`1070`	`1070`	`filename = estrndup(&ZSTR_VAL(tmpstr)[1], ZSTR_LEN(tmpstr) - 2);`
`1071`		`- filename[strlen(filename)] = '\0';`
`1072`	`1071`
`1073`	`1072`	`/* Check the basedir */`
`1074`	`1073`	`if (php_check_open_basedir(filename)) {`