Test returning objects

Author: DanielEScherzer

tests/output/ob_start_callback_bad_return/exception_handler.phpt

@@ -3,6 +3,16 @@ ob_start(): Check behaviour with deprecation converted to exception
 --FILE--
 <?php
 
+class NotStringable {
+    public function __construct(public string $val) {}
+}
+class IsStringable {
+    public function __construct(public string $val) {}
+    public function __toString() {
+        return __CLASS__ . ": " . $this->val;
+    }
+}
+
 $log = [];
 
 set_error_handler(function (int $errno, string $errstr, string $errfile, int $errline) {
@@ -33,7 +43,26 @@ function return_zero($string) {
     return 0;
 }
 
-$cases = ['return_null', 'return_false', 'return_true', 'return_zero'];
+function return_non_stringable($string) {
+    global $log;
+    $log[] = __FUNCTION__ . ": <<<" . $string . ">>>";
+    return new NotStringable($string);
+}
+
+function return_stringable($string) {
+    global $log;
+    $log[] = __FUNCTION__ . ": <<<" . $string . ">>>";
+    return new IsStringable($string);
+}
+
+$cases = [
+    'return_null',
+    'return_false',
+    'return_true',
+    'return_zero',
+    'return_non_stringable',
+    'return_stringable',
+];
 foreach ($cases as $case) {
     $log = [];
     echo "\n\nTesting: $case\n";
@@ -94,3 +123,25 @@ Stack trace:
 End of return_zero, log was:
 return_zero: <<<Inside of return_zero
 >>>
+
+Testing: return_non_stringable
+ErrorException: ob_end_flush(): Returning a non-string result from user output handler return_non_stringable is deprecated in %s:%d
+Stack trace:
+#0 [internal function]: {closure:%s:%d}(8192, 'ob_end_flush():...', '/usr/src/php/te...', 69)
+#1 %s(%d): ob_end_flush()
+#2 {main}
+
+End of return_non_stringable, log was:
+return_non_stringable: <<<Inside of return_non_stringable
+>>>
+
+Testing: return_stringable
+ErrorException: ob_end_flush(): Returning a non-string result from user output handler return_stringable is deprecated in %s:%d
+Stack trace:
+#0 [internal function]: {closure:%s:%d}(8192, 'ob_end_flush():...', '/usr/src/php/te...', 69)
+#1 %s(%d): ob_end_flush()
+#2 {main}
+
+End of return_stringable, log was:
+return_stringable: <<<Inside of return_stringable
+>>>

tests/output/ob_start_callback_bad_return/exception_handler_nested.phpt

@@ -3,6 +3,16 @@ ob_start(): Check behaviour with deprecation converted to exception
 --FILE--
 <?php
 
+class NotStringable {
+    public function __construct(public string $val) {}
+}
+class IsStringable {
+    public function __construct(public string $val) {}
+    public function __toString() {
+        return __CLASS__ . ": " . $this->val;
+    }
+}
+
 $log = [];
 
 set_error_handler(function (int $errno, string $errstr, string $errfile, int $errline) {
@@ -33,12 +43,40 @@ function return_zero($string) {
     return 0;
 }
 
+function return_non_stringable($string) {
+    global $log;
+    $log[] = __FUNCTION__ . ": <<<" . $string . ">>>";
+    return new NotStringable($string);
+}
+
+function return_stringable($string) {
+    global $log;
+    $log[] = __FUNCTION__ . ": <<<" . $string . ">>>";
+    return new IsStringable($string);
+}
+
 ob_start('return_null');
 ob_start('return_false');
 ob_start('return_true');
 ob_start('return_zero');
+ob_start('return_non_stringable');
+ob_start('return_stringable');
 
 echo "In all of them\n\n";
+try {
+    ob_end_flush();
+} catch (\ErrorException $e) {
+    echo $e->getMessage() . "\n";
+}
+echo "Ended return_stringable handler\n\n";
+
+try {
+    ob_end_flush();
+} catch (\ErrorException $e) {
+    echo $e->getMessage() . "\n";
+}
+echo "Ended return_non_stringable handler\n\n";
+
 try {
     ob_end_flush();
 } catch (\ErrorException $e) {
@@ -77,7 +115,15 @@ Ended return_null handler
 
 All handlers are over
 
-return_zero: <<<In all of them
+return_stringable: <<<In all of them
+
+>>>
+return_non_stringable: <<<ob_end_flush(): Returning a non-string result from user output handler return_stringable is deprecated
+Ended return_stringable handler
+
+>>>
+return_zero: <<<ob_end_flush(): Returning a non-string result from user output handler return_non_stringable is deprecated
+Ended return_non_stringable handler
 
 >>>
 return_true: <<<0ob_end_flush(): Returning a non-string result from user output handler return_zero is deprecated

tests/output/ob_start_callback_bad_return/handler_is_stringable_removed.phpt

@@ -0,0 +1,30 @@
+--TEST--
+ob_start(): Check behaviour with deprecation when OOM triggers handler removal (handler returns stringable object)
+--INI--
+memory_limit=2M
+--FILE--
+<?php
+
+class IsStringable {
+    public function __construct(public string $val) {}
+    public function __toString() {
+        return __CLASS__ . ": " . $this->val;
+    }
+}
+
+ob_start(function() {
+    // We are out of memory, now trigger a deprecation
+    return new IsStringable("");
+});
+
+$a = [];
+// trigger OOM in a resize operation
+while (1) {
+    $a[] = 1;
+}
+
+?>
+--EXPECTF--
+Deprecated: main(): Returning a non-string result from user output handler {closure:%s:%d} is deprecated in %s on line %d
+
+Fatal error: Allowed memory size of %d bytes exhausted%s(tried to allocate %d bytes) in %s on line %d

tests/output/ob_start_callback_bad_return/handler_non_stringable_removed.phpt

@@ -0,0 +1,32 @@
+--TEST--
+ob_start(): Check behaviour with deprecation when OOM triggers handler removal (handler returns non-stringable object)
+--INI--
+memory_limit=2M
+--FILE--
+<?php
+
+class NotStringable {
+    public function __construct(public string $val) {}
+}
+
+ob_start(function() {
+    // We are out of memory, now trigger a deprecation
+    return new NotStringable("");
+});
+
+$a = [];
+// trigger OOM in a resize operation
+while (1) {
+    $a[] = 1;
+}
+
+?>
+--EXPECTF--
+Deprecated: main(): Returning a non-string result from user output handler {closure:%s:%d} is deprecated in %s on line %d
+
+Fatal error: Allowed memory size of %d bytes exhausted%s(tried to allocate %d bytes) in %s on line %d
+
+Fatal error: Uncaught Error: Object of class NotStringable could not be converted to string in %s:%d
+Stack trace:
+#0 {main}
+  thrown in %s on line %d