Merge pull request #914 from uro/feature/async-command-extensions

async_commands: extended configuration proposal

Author: makasim

DependencyInjection/Configuration.php

@@ -76,6 +76,12 @@ private function getAsyncCommandsConfiguration(): ArrayNodeDefinition
         }
 
         return (new ArrayNodeDefinition('async_commands'))
+            ->children()
+                ->booleanNode('enabled')->defaultFalse()->end()
+                ->integerNode('timeout')->min(0)->defaultValue(60)->end()
+                ->scalarNode('command_name')->defaultNull()->end()
+                ->scalarNode('queue_name')->defaultNull()->end()
+            ->end()
             ->addDefaultsIfNotSet()
             ->canBeEnabled()
         ;

DependencyInjection/EnqueueExtension.php

@@ -363,14 +363,19 @@ private function loadReplyExtension(array $config, ContainerBuilder $container):
 
     private function loadAsyncCommands(array $config, ContainerBuilder $container): void
     {
-        $configNames = [];
+        $configs = [];
         foreach ($config as $name => $modules) {
             if (false === empty($modules['async_commands']['enabled'])) {
-                $configNames[] = $name;
+                $configs[] = [
+                    'name' => $name,
+                    'timeout' => $modules['async_commands']['timeout'],
+                    'command_name' => $modules['async_commands']['command_name'],
+                    'queue_name' => $modules['async_commands']['queue_name'],
+                ];
             }
         }
 
-        if (false == $configNames) {
+        if (false == $configs) {
             return;
         }
 
@@ -379,7 +384,7 @@ private function loadAsyncCommands(array $config, ContainerBuilder $container):
         }
 
         $extension = new AsyncCommandExtension();
-        $extension->load(['clients' => $configNames], $container);
+        $extension->load(['clients' => $configs], $container);
     }
 
     private function loadMessageQueueCollector(array $config, ContainerBuilder $container)

Tests/Functional/App/config/config.yml

@@ -28,7 +28,11 @@ enqueue:
             traceable_producer: true
         job: true
         async_events: true
-        async_commands: true
+        async_commands:
+            enabled: true
+            timeout: 60
+            command_name: ~
+            queue_name: ~
 
 services:
     test_enqueue.client.default.traceable_producer:
@@ -122,4 +126,4 @@ services:
     enqueue.events.async_listener:
         class: 'Enqueue\Bundle\Tests\Functional\App\AsyncListener'
         public: true
-        arguments: ['@enqueue.client.default.producer', '@enqueue.events.registry']
+        arguments: ['@enqueue.client.default.producer', '@enqueue.events.registry']