Skip to content

Commit ab98251

Browse files
committed
fix(otlp-gateway): use log_skip directive for health check suppression
- Replace invalid 'skip' log subdirective with 'log_skip' in handle block - Default suppressHealthChecks to false to avoid breaking existing deployments
1 parent c112bba commit ab98251

3 files changed

Lines changed: 6 additions & 15 deletions

File tree

charts/otlp-gateway/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
apiVersion: v2
22
name: otlp-gateway
3-
version: 0.54.0
3+
version: 0.55.0
44
description: A Helm chart for Kubernetes to deploy an OTLP gateway with authentication and authorization
55
type: application

charts/otlp-gateway/config/Caddyfile

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,9 @@
5151
{{- end }}
5252

5353
handle /api/health {
54+
{{- if .Values.log.suppressHealthChecks }}
55+
log_skip
56+
{{- end }}
5457
header Content-Type application/json
5558
respond "{\"status\": \"UP\"}" 200
5659
}
@@ -195,10 +198,6 @@
195198
resp_headers>X-Id-Token delete
196199
resp_headers>X-Api-Key delete
197200
}
198-
{{- if .Values.log.suppressHealthChecks }}
199-
# Suppress health check logs from kube-probe
200-
skip /api/health
201-
{{- end }}
202201
}
203202

204203
# Match external requests (Host header matches external FQDN)
@@ -221,10 +220,6 @@
221220
resp_headers>X-Id-Token delete
222221
resp_headers>X-Api-Key delete
223222
}
224-
{{- if .Values.log.suppressHealthChecks }}
225-
# Suppress health check logs from kube-probe
226-
skip /api/health
227-
{{- end }}
228223
}
229224

230225
import app_logic
@@ -255,10 +250,6 @@
255250
resp_headers>X-Id-Token delete
256251
resp_headers>X-Api-Key delete
257252
}
258-
{{- if .Values.log.suppressHealthChecks }}
259-
# Suppress health check logs from kube-probe
260-
skip /api/health
261-
{{- end }}
262253
}
263254

264255
import app_logic

charts/otlp-gateway/values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@ pyroscope:
7474

7575
log:
7676
level: error
77-
# Suppress health check logs (from kube-probe user agents)
78-
suppressHealthChecks: true
77+
# Suppress health check logs (/api/health endpoint)
78+
suppressHealthChecks: false
7979

8080
# CORS configuration for browser-based OTLP clients
8181
cors:

0 commit comments

Comments
 (0)