Change innerText to textContent in most places

In all of these cases, we don't care about the visibility properties of innerText.

Author: philc

make.js

@@ -224,7 +224,7 @@ task("fetch-tlds", [], async () => {
   const doc = new DOMParser().parseFromString(text, "text/html");
   const els = doc.querySelectorAll("span.domain.tld");
   // Each span contains a TLD, e.g. ".com". Trim off the leading period.
-  const domains = Array.from(els).map((el) => el.innerText.slice(1));
+  const domains = Array.from(els).map((el) => el.textContent.slice(1));
   const str = domains.join("\n");
   await Deno.writeTextFile("./resources/tlds.txt", str);
 });

pages/action.js

@@ -103,10 +103,10 @@ const ActionPage = {
       const patternMatchesUrl = this.tabUrl.match(regExp);
       if (patternMatchesUrl) {
         row.classList.remove("validationError");
-        validationEl.innerText = "";
+        validationEl.textContent = "";
       } else {
         row.classList.add("validationError");
-        validationEl.innerText = "Pattern does not match the current URL";
+        validationEl.textContent = "Pattern does not match the current URL";
       }
     }
   },
@@ -123,7 +123,7 @@ const ActionPage = {
       const hasBlankPassKeysRule = rules.find((r) => r.passKeys.length == 0);
       caption = hasBlankPassKeysRule ? "No" : "Some";
     }
-    document.querySelector("#how-many-enabled").innerText = caption;
+    document.querySelector("#how-many-enabled").textContent = caption;
   },
 
   async onSave() {

pages/hud_page.js

@@ -80,15 +80,15 @@ function ensureClipboardIsAvailable() {
 
 const handlers = {
   show(data) {
-    document.getElementById("hud").innerText = data.text;
+    document.getElementById("hud").textContent = data.text;
     document.getElementById("hud").classList.add("vimium-ui-component-visible");
     document.getElementById("hud").classList.remove("vimium-ui-component-hidden");
     document.getElementById("hud").classList.remove("hud-find");
   },
   hidden() {
     // We get a flicker when the HUD later becomes visible again (with new text) unless we reset its
     // contents here.
-    document.getElementById("hud").innerText = "";
+    document.getElementById("hud").textContent = "";
     document.getElementById("hud").classList.add("vimium-ui-component-hidden");
     document.getElementById("hud").classList.remove("vimium-ui-component-visible");
   },

pages/options.js

@@ -199,7 +199,7 @@ const OptionsPage = {
     const exampleEl = el.nextElementSibling;
     const messageEl = document.createElement("div");
     messageEl.classList.add("validation-message");
-    messageEl.innerText = message;
+    messageEl.textContent = message;
     exampleEl.after(messageEl);
   },