Fix nits

- Refactor some Zend checks.
- Fixed the segments alignment check - it is only for Linux and those
  matches processors.

Author: petk

cmake/Zend/cmake/CheckDlsym.cmake

@@ -1,35 +1,43 @@
 #[=============================================================================[
-# CheckDlsym
-
-Check if `dlsym()` requires a leading underscore in symbol name.
+Check if dlsym() requires a leading underscore in symbol name.
 
 Some non-ELF platforms, such as OpenBSD, FreeBSD, NetBSD, Mac OSX (~10.3),
-needed underscore character (`_`) prefix for symbols, when using `dlsym()`. This
+needed to prefix symbols with underscore character (_), when using dlsym(). This
 module is obsolete on current platforms.
 
-## Cache variables
+Result variables:
 
-* `DLSYM_NEEDS_UNDERSCORE`
+* DLSYM_NEEDS_UNDERSCORE
 #]=============================================================================]
 
 include_guard(GLOBAL)
 
+set(DLSYM_NEEDS_UNDERSCORE FALSE)
+
+if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
+  return()
+endif()
+
 # Skip in consecutive configuration phases.
-if(DEFINED DLSYM_NEEDS_UNDERSCORE)
+if(DEFINED PHP_ZEND_HAS_DLSYM_NEEDS_UNDERSCORE)
+  if(PHP_ZEND_HAS_DLSYM_NEEDS_UNDERSCORE)
+    set(DLSYM_NEEDS_UNDERSCORE TRUE)
+  endif()
+
   return()
 endif()
 
 include(CheckIncludeFiles)
 
 message(
   CHECK_START
-  "Checking whether dlsym() requires a leading underscore in symbol names"
+  "Checking whether dlsym() needs to prefix symbols with underscore"
 )
 
+# When cross-compiling without emulator, assume that target platform is recent
+# enough so that dlsym doesn't need leading underscores.
 if(CMAKE_CROSSCOMPILING AND NOT CMAKE_CROSSCOMPILING_EMULATOR)
-  # When cross-compiling without emulator, assume that target platform is recent
-  # enough so that dlsym doesn't need leading underscores.
-  set(DLSYM_NEEDS_UNDERSCORE_EXITCODE 0)
+  set(PHP_ZEND_HAS_DLSYM_NEEDS_UNDERSCORE_EXITCODE 0)
 endif()
 
 check_include_files(dlfcn.h HAVE_DLFCN_H)
@@ -40,8 +48,8 @@ block()
   endif()
 
   try_run(
-    DLSYM_NEEDS_UNDERSCORE_EXITCODE
-    DLSYM_NEEDS_UNDERSCORE_COMPILED
+    PHP_ZEND_HAS_DLSYM_NEEDS_UNDERSCORE_EXITCODE
+    PHP_ZEND_HAS_DLSYM_NEEDS_UNDERSCORE_COMPILED
     SOURCE_FROM_CONTENT src.c [[
       #ifdef HAVE_DLFCN_H
       # include <dlfcn.h>
@@ -116,16 +124,20 @@ block()
 endblock()
 
 set(
-  DLSYM_NEEDS_UNDERSCORE
+  PHP_ZEND_HAS_DLSYM_NEEDS_UNDERSCORE
   ""
   CACHE INTERNAL
   "Whether 'dlsym()' requires a leading underscore in symbol names."
 )
 
-if(DLSYM_NEEDS_UNDERSCORE_COMPILED AND DLSYM_NEEDS_UNDERSCORE_EXITCODE EQUAL 2)
-  set_property(CACHE DLSYM_NEEDS_UNDERSCORE PROPERTY VALUE TRUE)
-  message(CHECK_PASS "yes")
+if(
+  PHP_ZEND_HAS_DLSYM_NEEDS_UNDERSCORE_COMPILED
+  AND PHP_ZEND_HAS_DLSYM_NEEDS_UNDERSCORE_EXITCODE EQUAL 2
+)
+  set_property(CACHE PHP_ZEND_HAS_DLSYM_NEEDS_UNDERSCORE PROPERTY VALUE TRUE)
+  set(DLSYM_NEEDS_UNDERSCORE TRUE)
+  message(CHECK_FAIL "yes")
 else()
-  set_property(CACHE DLSYM_NEEDS_UNDERSCORE PROPERTY VALUE FALSE)
-  message(CHECK_FAIL "no")
+  set_property(CACHE PHP_ZEND_HAS_DLSYM_NEEDS_UNDERSCORE PROPERTY VALUE FALSE)
+  message(CHECK_PASS "no")
 endif()

cmake/Zend/cmake/CheckFloatPrecision.cmake

@@ -1,38 +1,16 @@
 #[=============================================================================[
-# CheckFloatPrecision
-
 Check for x87 floating point internal precision control.
 
 See: https://wiki.php.net/rfc/rounding
 
-## Cache variables
-
-* `HAVE__FPU_SETCW`
-
-  Whether `_FPU_SETCW` is present and usable.
-
-* `HAVE_FPSETPREC`
-
-  Whether `fpsetprec` is present and usable.
-
-* `HAVE__CONTROLFP`
-
-  Whether `_controlfp` is present and usable.
-
-* `HAVE__CONTROLFP_S`
-
-  Whether `_controlfp_s` is present and usable.
-
-* `HAVE_FPU_INLINE_ASM_X86`
-
-  Whether FPU control word can be manipulated by inline assembler.
-
-## Usage
+Cache variables:
 
-```cmake
-# CMakeLists.txt
-include(cmake/CheckFloatPrecision.cmake)
-```
+* HAVE__FPU_SETCW - Whether _FPU_SETCW is present and usable.
+* HAVE_FPSETPREC - Whether fpsetprec is present and usable.
+* HAVE__CONTROLFP - Whether _controlfp is present and usable.
+* HAVE__CONTROLFP_S - Whether _controlfp_s is present and usable.
+* HAVE_FPU_INLINE_ASM_X86 - Whether FPU control word can be manipulated by
+  inline assembler.
 #]=============================================================================]
 
 include_guard(GLOBAL)

cmake/Zend/cmake/CheckGlobalRegisterVariables.cmake

@@ -1,30 +1,22 @@
 #[=============================================================================[
-# CheckGlobalRegisterVariables
-
 Check whether the compiler and target system support global register variables.
-
 Global register variables are relevant for the GNU C compatible compilers.
+See also https://gcc.gnu.org/onlinedocs/gcc/Global-Register-Variables.html
 
-See also: [GCC global register variables](https://gcc.gnu.org/onlinedocs/gcc/Global-Register-Variables.html)
-
-## Cache variables
-
-* `HAVE_GCC_GLOBAL_REGS`
+Result variables:
 
-  Whether global register variables are supported.
-
-## Usage
-
-```cmake
-# CMakeLists.txt
-include(cmake/CheckGlobalRegisterVariables.cmake)
-```
+* HAVE_GCC_GLOBAL_REGS - Whether global register variables are supported.
 #]=============================================================================]
 
 include_guard(GLOBAL)
 
+set(HAVE_GCC_GLOBAL_REGS FALSE)
+
 # Skip in consecutive configuration phases.
-if(DEFINED HAVE_GCC_GLOBAL_REGS)
+if(DEFINED PHP_ZEND_HAS_GCC_GLOBAL_REGS)
+  if(PHP_ZEND_HAS_GCC_GLOBAL_REGS)
+    set(HAVE_GCC_GLOBAL_REGS TRUE)
+  endif()
   return()
 endif()
 
@@ -83,10 +75,11 @@ cmake_push_check_state(RESET)
     {
       return 0;
     }
-  ]] HAVE_GCC_GLOBAL_REGS)
+  ]] PHP_ZEND_HAS_GCC_GLOBAL_REGS)
 cmake_pop_check_state()
 
-if(HAVE_GCC_GLOBAL_REGS)
+if(PHP_ZEND_HAS_GCC_GLOBAL_REGS)
+  set(HAVE_GCC_GLOBAL_REGS TRUE)
   message(CHECK_PASS "yes")
 else()
   message(CHECK_FAIL "no")

cmake/Zend/cmake/CheckMMAlignment.cmake

@@ -1,21 +1,12 @@
 #[=============================================================================[
-# CheckMMAlignment
-
 Test and set the alignment defines for the Zend memory manager (`ZEND_MM`). This
 also does the logarithmic test.
 
-## Result variables
-
-* `ZEND_MM_ALIGNMENT`
-* `ZEND_MM_ALIGNMENT_LOG2`
-* `ZEND_MM_NEED_EIGHT_BYTE_REALIGNMENT`
-
-## Usage
+Result variables:
 
-```cmake
-# CMakeLists.txt
-include(cmake/CheckMMAlignment.cmake)
-```
+* ZEND_MM_ALIGNMENT
+* ZEND_MM_ALIGNMENT_LOG2
+* ZEND_MM_NEED_EIGHT_BYTE_REALIGNMENT
 #]=============================================================================]
 
 include_guard(GLOBAL)

cmake/Zend/cmake/CheckStackDirection.cmake

@@ -1,20 +1,9 @@
 #[=============================================================================[
-# CheckStackDirection
-
 Check whether the stack grows downwards. Assumes contiguous stack.
 
-## Cache variables
-
-* `ZEND_CHECK_STACK_LIMIT`
-
-  Whether checking the stack limit is supported.
-
-## Usage
+Result/cache variables:
 
-```cmake
-# CMakeLists.txt
-include(cmake/CheckStackDirection.cmake)
-```
+* ZEND_CHECK_STACK_LIMIT - Whether checking the stack limit is supported.
 #]=============================================================================]
 
 include_guard(GLOBAL)
@@ -24,6 +13,11 @@ if(DEFINED ZEND_CHECK_STACK_LIMIT)
   return()
 endif()
 
+if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
+  set(ZEND_CHECK_STACK_LIMIT TRUE)
+  return()
+endif()
+
 include(CheckSourceRuns)
 include(CMakePushCheckState)
 

cmake/Zend/cmake/CheckStrerrorR.cmake

@@ -1,26 +1,12 @@
 #[=============================================================================[
-# CheckStrerrorR
-
-Check whether `strerror_r()` is the POSIX-compatible version or the GNU-specific
+Check whether strerror_r() is the POSIX-compatible version or the GNU-specific
 version.
 
-## Cache variables
-
-* `HAVE_STRERROR_R`
-
-  Whether `strerror_r()` is available.
-
-* `STRERROR_R_CHAR_P`
-
-  Whether `strerror_r()` returns a `char *` message, otherwise it returns an
-  `int` error number.
+Result variables:
 
-## Usage
-
-```cmake
-# CMakeLists.txt
-include(cmake/CheckStrerrorR.cmake)
-```
+* HAVE_STRERROR_R - Whether strerror_r() is available.
+* STRERROR_R_CHAR_P - Whether strerror_r() returns a 'char *' message, otherwise
+  it returns an 'int' error number.
 #]=============================================================================]
 
 include_guard(GLOBAL)
@@ -29,14 +15,35 @@ include(CheckSourceCompiles)
 include(CheckSymbolExists)
 include(CMakePushCheckState)
 
-check_symbol_exists(strerror_r string.h HAVE_STRERROR_R)
+set(HAVE_STRERROR_R FALSE)
+set(STRERROR_R_CHAR_P FALSE)
 
-if(NOT HAVE_STRERROR_R)
+if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
   return()
 endif()
 
+check_symbol_exists(strerror_r string.h PHP_ZEND_HAS_STRERROR_R)
+
+if(NOT PHP_ZEND_HAS_STRERROR_R)
+  return()
+endif()
+
+set(HAVE_STRERROR_R TRUE)
+
+# Skip in consecutive configuration phases.
+if(DEFINED PHP_ZEND_HAS_STRERROR_R_CHAR_P)
+  if(PHP_ZEND_HAS_STRERROR_R_CHAR_P)
+    set(STRERROR_R_CHAR_P TRUE)
+    return()
+  endif()
+endif()
+
+message(CHECK_START "Checking strerror_r() return type")
+
 cmake_push_check_state(RESET)
   set(CMAKE_REQUIRED_DEFINITIONS -D_GNU_SOURCE)
+  set(CMAKE_REQUIRED_QUIET TRUE)
+
   check_source_compiles(C [[
     #include <string.h>
 
@@ -47,5 +54,12 @@ cmake_push_check_state(RESET)
       char *p = strerror_r (0, buf, sizeof buf);
       return !p || x;
     }
-  ]] STRERROR_R_CHAR_P)
+  ]] PHP_ZEND_HAS_STRERROR_R_CHAR_P)
 cmake_pop_check_state()
+
+if(PHP_ZEND_HAS_STRERROR_R_CHAR_P)
+  set(STRERROR_R_CHAR_P TRUE)
+  message(CHECK_PASS "char *")
+else()
+  message(CHECK_PASS "int")
+endif()

cmake/Zend/cmake/Fibers.cmake

@@ -1,36 +1,24 @@
 #[=============================================================================[
-# Fibers
-
 Check if Fibers can be used.
 
 This module adds Boost fiber assembly files support if available for the
 platform, otherwise it checks if ucontext can be used.
 
-## Control variables
-
-* `ZEND_FIBER_ASM`
-
-  Whether to use Boost fiber assembly files.
+Control variables:
 
-## Cache variables
+* ZEND_FIBER_ASM - Whether to use Boost fiber assembly files.
 
-* `ZEND_FIBER_UCONTEXT`
+Cache variables:
 
-  Whether `<ucontext.h>` header file is available and should be used.
+* ZEND_FIBER_UCONTEXT - Whether <ucontext.h> header file is available and should
+  be used.
 
-## Interface library
+Interface library:
 
-* `Zend::Fibers`
+* Zend::Fibers
 
   Interface library using Boost fiber assembly files and compile options if
   available.
-
-## Usage
-
-```cmake
-# CMakeLists.txt
-include(cmake/Fibers.cmake)
-```
 #]=============================================================================]
 
 include_guard(GLOBAL)