Skip to content

Commit 3e856da

Browse files
ancientwizarddjzort
authored andcommitted
These calls randomly SEGV during logging in cnx_detach().
OCISessionEnd_log_stat() OCIServerDetach_log_stat()
1 parent 316bf1f commit 3e856da

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

dbdcnx.c

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1042,8 +1042,17 @@ cnx_detach(pTHX_ imp_dbh_t * imp_dbh)
10421042

10431043
sword status = OCI_SUCCESS;
10441044

1045-
OCISessionEnd_log_stat( imp_dbh, imp_dbh->svchp, imp_dbh->errhp, imp_dbh->seshp, OCI_DEFAULT, status );
1046-
OCIServerDetach_log_stat( imp_dbh, imp_dbh->srvhp, imp_dbh->errhp, OCI_DEFAULT, status );
1045+
// GLOBAL Perl END's may cause these to SEGV doe to filehandles (just a guess).
1046+
// The person thay left off the logging in the first place should have provided a clue
1047+
// assuming thay knew what the issue was.
1048+
// I thought I was being clever by adding the logging to these OCI calls;
1049+
// or at least help to debug the original SEGV issue.
1050+
1051+
// OCISessionEnd_log_stat( imp_dbh, imp_dbh->svchp, imp_dbh->errhp, imp_dbh->seshp, OCI_DEFAULT, status );
1052+
// OCIServerDetach_log_stat( imp_dbh, imp_dbh->srvhp, imp_dbh->errhp, OCI_DEFAULT, status );
1053+
1054+
OCISessionEnd( imp_dbh->svchp, imp_dbh->errhp, imp_dbh->seshp, OCI_DEFAULT );
1055+
OCIServerDetach( imp_dbh->srvhp, imp_dbh->errhp, OCI_DEFAULT );
10471056

10481057
#ifdef ORA_OCI_112
10491058
}

0 commit comments

Comments
 (0)