-
Notifications
You must be signed in to change notification settings - Fork 31
Judging Utilities (QuickJudgePane) does not initially populate judge column #1239
Copy link
Copy link
Open
Labels
CI - Continuous ImprovementContinuously improve pc2 code quality, features and testingContinuously improve pc2 code quality, features and testingDeveloper IssueAn issue which affects PC2 Developers but doesn't directly affect users.An issue which affects PC2 Developers but doesn't directly affect users.NEXT ContestConsider fixing for next contetConsider fixing for next contetOne ApprovalA very low risk and low LOE PR/ChangeA very low risk and low LOE PR/ChangeSmall LOELess than an hour to code, test and push a PRLess than an hour to code, test and push a PR
Metadata
Metadata
Assignees
Labels
CI - Continuous ImprovementContinuously improve pc2 code quality, features and testingContinuously improve pc2 code quality, features and testingDeveloper IssueAn issue which affects PC2 Developers but doesn't directly affect users.An issue which affects PC2 Developers but doesn't directly affect users.NEXT ContestConsider fixing for next contetConsider fixing for next contetOne ApprovalA very low risk and low LOE PR/ChangeA very low risk and low LOE PR/ChangeSmall LOELess than an hour to code, test and push a PRLess than an hour to code, test and push a PR
Describe the issue:
The "Judge" column is blank initially and when the View Unjudged Only checkbox is checked or unchecked.
To Reproduce:
Load a contest that has judged runs.
Bring up an administrator client.
On the Run Contest tab, sick "Judging Utilities" (formerly @lane55's "Quick Judge")
Uncheck the "View Unjudged Only" checkbox.
Note that the Judge column is blank.
Expected behavior:
Each judged run should show which judge judged it.
Actual behavior:
Unless filtering is enabled, the Judged column is blank.
Environment:
All.
Log Info:
Screenshots:
Additional context:
The
updateRunListDisplay()routine inQuickJudgePane.javahas to lookup the judgement record and pull the judge's client id from it:judgementRecord.getJudgerClientId(). This should then be passed toupdateRunRow()instead of 'null'.