-
Notifications
You must be signed in to change notification settings - Fork 31
Handle ignore_sample if no sample group is present #1231
Copy link
Copy link
Open
Labels
CI - Continuous ImprovementContinuously improve pc2 code quality, features and testingContinuously improve pc2 code quality, features and testingNEXT ContestConsider fixing for next contetConsider fixing for next contetOne ApprovalA very low risk and low LOE PR/ChangeA very low risk and low LOE PR/ChangePrimary CCSRequired for PC2 to act as primary CCSRequired for PC2 to act as primary CCSgood first issueGood for newcomersGood for newcomershigh priorityBugs that are high priority (to fix)Bugs that are high priority (to fix)
Metadata
Metadata
Assignees
Labels
CI - Continuous ImprovementContinuously improve pc2 code quality, features and testingContinuously improve pc2 code quality, features and testingNEXT ContestConsider fixing for next contetConsider fixing for next contetOne ApprovalA very low risk and low LOE PR/ChangeA very low risk and low LOE PR/ChangePrimary CCSRequired for PC2 to act as primary CCSRequired for PC2 to act as primary CCSgood first issueGood for newcomersGood for newcomershigh priorityBugs that are high priority (to fix)Bugs that are high priority (to fix)
Is your feature request related to a problem?
This is an enhancement for a misconfigured contest.
...
Feature Description:
If the ignore_sample grader flag is set and there is no sample test data group, just log a warning message instead of causing an error.
...
Have you considered other ways to accomplish the same thing?
The top level
testdata.yamlin thedatafolder can be edited to remove the ignore_sample grader_flag....
Do you have any specific suggestions for how your feature would be implemented in PC^2?
Make a small modification to the LegacyGrader.
...
Additional context:
Noticed at the NAC2026.
...