-
Notifications
You must be signed in to change notification settings - Fork 31
Change default scoreboard ranking to not use WF Group ranking #1219
Copy link
Copy link
Open
Labels
Analysis requiredRoot cause unknown or requirements analysis requiredRoot cause unknown or requirements analysis requiredCI - Continuous ImprovementContinuously improve pc2 code quality, features and testingContinuously improve pc2 code quality, features and testingPrimary CCSRequired for PC2 to act as primary CCSRequired for PC2 to act as primary CCSSmall LOELess than an hour to code, test and push a PRLess than an hour to code, test and push a PRmedium-highShould be consider for next releaseShould be consider for next release
Description
Metadata
Metadata
Assignees
Labels
Analysis requiredRoot cause unknown or requirements analysis requiredRoot cause unknown or requirements analysis requiredCI - Continuous ImprovementContinuously improve pc2 code quality, features and testingContinuously improve pc2 code quality, features and testingPrimary CCSRequired for PC2 to act as primary CCSRequired for PC2 to act as primary CCSSmall LOELess than an hour to code, test and push a PRLess than an hour to code, test and push a PRmedium-highShould be consider for next releaseShould be consider for next release
Is your feature request related to a problem?
It has been suggested by @clevengr that we ONLY use
FinalizeData.useWFGroupRankingfor WF contests... in which case setting that tofalseinstead oftruemight be a more logical default?In addition, there is currently no way to define the type of scoreboard ranking desire nor the number of medals in the
system.pc2.yamlfile (or any configuration file for that matter). There should be a way to configure these settings using configuration files (specifically,system.pc2.yaml) and not have to rely on changing them manually using the GUI....
Feature Description:
Change the default scoreboard ranking to not use WF Group ranking.
Add a way to configure the scoreboard ranking type and medal counts using the
system.pc2.yamlfile....
Have you considered other ways to accomplish the same thing?
It can be done manually on the Run Contest->Finalize tab.
...
Do you have any specific suggestions for how your feature would be implemented in PC^2?
In FinalizeData.java, change the initialization of
useWFGroupRankingto false. Also, either remove the call tosetUseWFGroupRanking(true)inFinalizeData.getDefaultFinalizeData(), or, change it tofalse. The setting in theFinalsStandingsRecordComparator.javashould also be changed tofalseforuseWFGroupRanking.The
GenDefaultFinalizeData()method inResultsFile.javashould be removed and the call in that same module to that method should be replaced withFinalize.getDefaultFinalizeData().Fix ContestSnakeYAMLLoader to allow configuring the FinalizeData.
...
Additional context:
Created as a result of PR #1210
...