Skip to content

Button - update console error for accessible name and move aria-expanded location #11871

@thatblindgeye

Description

@thatblindgeye

Describe the enhancement or change
Followup to some comments left in #11861

  • The console error with the isSettings || isHamburger || isFavorite conditional for the accessible name (line 164 in that PR) should be updated to remove that conditional. We should be throwing an error for any button that doesn't have children, aria-label, or aria-labelledby
  • The aria-expanded attribute (line 239) should be moved below the {...props} so that it won't be overridden by a manual aria-expanded being passed in
  • Several tests related to the above points will need to be updated in some fashion as well

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?

Any other information?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Breaking change 💥this change requires a major release and has API changes.PF Team

    Projects

    Status

    Needs triage

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions