perf(net): drain satellite messages in Sink impl for FCFS ordering #20182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves buffer drain logic from Stream::poll_next to Sink::poll_ready and Sink::poll_flush to ensure satellite protocol messages are sent in first-come-first-served order. Changes: - Stream::poll_next now sends only one buffered message per poll (full drain happens in Sink impl) - Sink::poll_ready drains entire out_buffer before checking primary - Sink::poll_flush drains buffer and flushes both conn and primary - Sink::poll_close closes both conn and primary - Added io::Error bound for proper error conversion Closes paradigmxyz#13856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13856