perf: avoid duplicate storage get call #20180
Merged
+43
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested review from
Rjected,
fgimenez,
mediocregopher and
yongkangc
as code owners
mattsse
added
the
C-perf
yongkangc
approved these changes
Dec 8, 2025
shekhirin
approved these changes
Dec 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
yongkangc
pushed a commit
that referenced
this pull request
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20145
see docs re race condition for the case when two tasks (e.g. prewarming) compete for the same account.
I think we can ignore this case, if this is a hot contract and multiple different prewarming looking up different slots at the same time, then we can assume that this only happens when the cache was invalidated/empty.