feat: add support for debug_getBadBlock #20177
Open
+221
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKarl98
requested review from
Rjected,
fgimenez,
gakonst,
klkvr,
mattsse,
mediocregopher and
shekhirin
as code owners
klkvr
reviewed
Dec 7, 2025
Member
klkvr
left a comment
klkvr
left a comment
There was a problem hiding this comment.
would prefer us to avoid doing breaking changes for this
Comment on lines
1029
to
1043
| // keep track of invalid blocks for `debug_getBadBlocks` only if debug RPC is enabled | ||
| if debug_enabled { | ||
| let bad_block_store = registry.bad_block_store().clone(); | ||
| let mut engine_events_stream = engine_events.new_listener(); | ||
| node.task_executor().spawn(Box::pin(async move { | ||
| while let Some(event) = engine_events_stream.next().await { | ||
| if let ConsensusEngineEvent::InvalidBlock(block) = event && | ||
| let Ok(recovered) = | ||
| RecoveredBlock::try_recover_sealed(block.as_ref().clone()) | ||
| { | ||
| bad_block_store.insert(recovered); | ||
| } | ||
| } | ||
| })); | ||
| } |
Member
There was a problem hiding this comment.
hmm can we not have this being handled by DebugApi itself?
Contributor
Author
There was a problem hiding this comment.
Have moved this part of logic to inside DebugApi
crates/rpc/rpc-eth-api/src/types.rs
Outdated
Comment on lines
19
to
33
| pub trait EthApiTypes: RpcNodeCore + Send + Sync + Clone { | ||
| /// Extension of [`FromEthApiError`], with network specific errors. | ||
| type Error: Into<jsonrpsee_types::error::ErrorObject<'static>> | ||
| + FromEthApiError | ||
| + AsEthApiError | ||
| + From<<Self::RpcConvert as RpcConvert>::Error> | ||
| + Error | ||
| + Send | ||
| + Sync; | ||
| /// Blockchain primitive types, specific to network, e.g. block and transaction. | ||
| type NetworkTypes: RpcTypes; | ||
| /// Conversion methods for transaction RPC type. | ||
| type RpcConvert: RpcConvert<Network = Self::NetworkTypes>; | ||
| /// Provider block type used by RPC. | ||
| type ProviderBlock: BlockTrait; |
Member
There was a problem hiding this comment.
would prefer us to avoid changing this trait
Contributor
Author
There was a problem hiding this comment.
Have revert changes to this trait , it remains the same as before
Comment on lines
+70
to
+73
| + reth_ethereum::rpc::eth::RpcNodeCore< | ||
| Provider = Node::Provider, | ||
| Primitives = <Node::Types as NodeTypes>::Primitives, | ||
| >, |
Member
There was a problem hiding this comment.
hmm unclear why this is needed. I know that those bounds are sometimes problematic but we need to figure out solutions for this that don't break such user-facing APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This targets on issue #20123 , as below :
Add a shared BadBlockStore (bounded, deduped, newest-first) and wire it into DebugApi
Implement debug_getBadBlocks to expose recent invalid blocks with full transactions, hash, and RLP
Listen for ConsensusEngineEvent::InvalidBlock, recover the sealed block with senders, and cache it for the debug API
cc @mattsse @klkvr @Rjected